Skip to content

Commit 63f6e49

Browse files
committed
Merge pull request #20 from yllieth/last-time-api-modifs
Last time api modifs
2 parents a71f1f2 + 79d749c commit 63f6e49

File tree

9 files changed

+48
-12
lines changed

9 files changed

+48
-12
lines changed

.gitignore

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,3 +2,5 @@ node_modules
22
vendor
33
.idea
44
npm-debug.log
5+
.DS_Store
6+
.DS_Store?

bower.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "predicsis_ml_sdk-javascript",
3-
"version": "0.4.0",
3+
"version": "0.4.1",
44
"authors": [
55
"Yllieth <[email protected]>",
66
"Dehau"

dist/predicsis-jsSDK.js

Lines changed: 21 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -467,13 +467,17 @@ angular
467467
*
468468
* @param {String} fileName used to create the source and the dataset
469469
* @param {String} destFolder AWS key where the dataset has been uploaded
470+
* @param {String} pathName name of the key used to provide destFolder
470471
* @return {Promise} Newly created dataset
471472
*/
472-
this.createFromUpload = function(fileName, destFolder) {
473+
this.createFromUpload = function(fileName, destFolder, pathName) {
474+
pathName = pathName || 'key';
473475

474476
var Sources = $injector.get('Sources');
477+
var source = { name: fileName, data_file: { filename: fileName } };
478+
source[pathName] = destFolder;
475479

476-
return Sources.create({ path: destFolder, name: fileName, data_file: { filename: fileName } })
480+
return Sources.create(source)
477481
.then(function(source) {
478482
return self.create({
479483
name: fileName,
@@ -2855,8 +2859,14 @@ angular
28552859
* key: "path/to/my/file/on/s3/source.csv",
28562860
* }
28572861
* </pre>
2862+
* <pre>
2863+
* {
2864+
* name: "Source of dataset.csv"
2865+
* object: "path/to/my/file/on/s3/source.csv",
2866+
* }
2867+
* </pre>
28582868
*
2859-
* Both <code>name</code> and <code>key</code> are required.
2869+
* Both <code>name</code> and <code>key | object</code> are required.
28602870
*
28612871
* @param {Object} params See above example.
28622872
* @return {Promise} New source
@@ -3420,6 +3430,7 @@ angular
34203430
var uploadObject = concurrentUploads[uploadId] = {
34213431
id: uploadId,
34223432
path: null,
3433+
pathName: null,
34233434
fileName: file.name,
34243435
fileSize: file.size,
34253436
progression: 0,
@@ -3437,7 +3448,13 @@ angular
34373448
Sources
34383449
.getCredentials(storageService)
34393450
.then(function(credentials) {
3440-
uploadObject.path = credentials.path
3451+
if (credentials.type === 's3') {
3452+
uploadObject.path = credentials.key;
3453+
uploadObject.pathName = 'key';
3454+
} else if (credentials.type === 'swift') {
3455+
uploadObject.path = credentials.object;
3456+
uploadObject.pathName = 'object';
3457+
}
34413458
upload(uploadObject, xhr2, credentials, file);
34423459
});
34433460
};

dist/predicsis-jsSDK.min.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/predicsis-jsSDK.min.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

lib/helper/uploadHelper.js

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -123,6 +123,7 @@ angular
123123
var uploadObject = concurrentUploads[uploadId] = {
124124
id: uploadId,
125125
path: null,
126+
pathName: null,
126127
fileName: file.name,
127128
fileSize: file.size,
128129
progression: 0,
@@ -140,7 +141,13 @@ angular
140141
Sources
141142
.getCredentials(storageService)
142143
.then(function(credentials) {
143-
uploadObject.path = credentials.path
144+
if (credentials.type === 's3') {
145+
uploadObject.path = credentials.key;
146+
uploadObject.pathName = 'key';
147+
} else if (credentials.type === 'swift') {
148+
uploadObject.path = credentials.object;
149+
uploadObject.pathName = 'object';
150+
}
144151
upload(uploadObject, xhr2, credentials, file);
145152
});
146153
};

lib/model/Datasets.js

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -240,13 +240,17 @@ angular
240240
*
241241
* @param {String} fileName used to create the source and the dataset
242242
* @param {String} destFolder AWS key where the dataset has been uploaded
243+
* @param {String} pathName name of the key used to provide destFolder ('key' for S3, 'object' for swift)
243244
* @return {Promise} Newly created dataset
244245
*/
245-
this.createFromUpload = function(fileName, destFolder) {
246+
this.createFromUpload = function(fileName, destFolder, pathName) {
247+
pathName = pathName || 'key';
246248

247249
var Sources = $injector.get('Sources');
250+
var source = { name: fileName, data_file: { filename: fileName } };
251+
source[pathName] = destFolder;
248252

249-
return Sources.create({ path: destFolder, name: fileName, data_file: { filename: fileName } })
253+
return Sources.create(source)
250254
.then(function(source) {
251255
return self.create({
252256
name: fileName,

lib/model/Sources.js

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,8 +86,14 @@ angular
8686
* key: "path/to/my/file/on/s3/source.csv",
8787
* }
8888
* </pre>
89+
* <pre>
90+
* {
91+
* name: "Source of dataset.csv"
92+
* object: "path/to/my/file/on/s3/source.csv",
93+
* }
94+
* </pre>
8995
*
90-
* Both <code>name</code> and <code>key</code> are required.
96+
* Both <code>name</code> and <code>key | object</code> are required.
9197
*
9298
* @param {Object} params See above example.
9399
* @return {Promise} New source

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "predicsis_ml_sdk-javascript",
3-
"version": "0.4.0",
3+
"version": "0.4.1",
44
"description": "Javascript SDK for PredicSis ML API",
55
"main": "index.js",
66
"scripts": {

0 commit comments

Comments
 (0)