Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request for the correct version of the code to regenerate the same paper results? #3

Open
BassantTolba1234 opened this issue Aug 7, 2022 · 4 comments

Comments

@BassantTolba1234
Copy link

Dear Prof,
please can you kindly share the correct version of the code resulting in the same results in the paper?
I'm waiting for your reply.
Thanks a lot.

@yingmao
Copy link
Owner

yingmao commented Aug 19, 2022

Hi BassantToblba1234,

We are not sure what is your question. This is the code that we used to generate our results. It includes multiple different configurations, such as PCA.

@BassantTolba1234
Copy link
Author

BassantTolba1234 commented Aug 19, 2022 via email

@yingmao
Copy link
Owner

yingmao commented Aug 19, 2022

Hi BassantTolba1234,

We did not provide the code for TFQ-GANs and Qi-GANs as they were basically TensorFlow and Qiskit based implementations with default loss functions. You can check the papers below.

Quantum generative adversarial networks for learning and loading random distributions (Qi-GAN)
Tensorflow quantum: A software framework for quantum machine learning (Combining TFQ and TF)

As for QuGAN, due to random seeds (within Qiskit simulators), you won't see exactly the same values. However, you should see similar trends. I'm not sure what values and trends of Hellinger distance you obtained. We can answer specific questions related to the code, such as PCA dimensions, data labels, and parameter values.

@BassantTolba1234
Copy link
Author

BassantTolba1234 commented Aug 19, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants