Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Built-in Support for Yandex Rules for Cyrillic #76

Closed
ilyaigpetrov opened this issue Jul 21, 2018 · 1 comment
Closed

Feature: Built-in Support for Yandex Rules for Cyrillic #76

ilyaigpetrov opened this issue Jul 21, 2018 · 1 comment

Comments

@ilyaigpetrov
Copy link

ilyaigpetrov commented Jul 21, 2018

I don't like the transliteration rules used for Cyrillic and want to use Yandex rules (for names, on the map, etc.) instead (Yandex.Money also have rules for credit cards, just in case).
One solution to my problem is to use replace config, but in #57 @andyhu states:

...using 'replace' option to do it seems not an ideal solution. Because it uses a global regex replace. If there are many replaces and the text is very long, considering it's not implement as an async function, it may freeze the node process.

So I guess better solution would be to support Yandex rules out of the box and in this issue I ask for this.
I would write a patch myself, but considering you plan some drastic changes for 2.0, I don't do this.
Let me know if I may help you implementing Yandex rules support.

Thanks.

UPD

What is the source for current transliteration rules for Cyrillic in charmap.json? Was it built with Google Transliteration API or other way?

@ilyaigpetrov ilyaigpetrov changed the title Feature: Built-in Support for Yandex Rules Feature: Built-in Support for Yandex Rules for Cyrillic Jul 21, 2018
@ilyaigpetrov
Copy link
Author

ilyaigpetrov commented Jul 21, 2018

I wasn't attentive: the Yandex rules I referenced are for names (on the map, etc.). I doubt I need transliterating names. Sorry for disturbing. I hope the rules of transliteration you use are from a good source and I may trust them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant