Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discussion, questions, notes, planning for the new CLJS dashboard #1

Open
2 of 6 tasks
devth opened this issue Apr 3, 2020 · 6 comments
Open
2 of 6 tasks

Discussion, questions, notes, planning for the new CLJS dashboard #1

devth opened this issue Apr 3, 2020 · 6 comments
Assignees

Comments

@devth
Copy link
Member

devth commented Apr 3, 2020

Should we use Reagent? Reframe? @kaffein has volunteered to lead this 😁

@kaffein
Copy link
Member

kaffein commented Apr 3, 2020

I think since it's the first time we introduce a pure cljs-based frontend on the project, we're going to evaluate and assess each option first and based on that we'll make a choice. But from a very practical aspect, I would say that going for re-agent first is the simplest path and if the need arises we can go beyond re-agent and add re-frame 😊.

Of course, feel free to comment here if you guys have ideas or suggestions, especially if you have frontend experience on cljs. We are here first and foremost to learn and have fun together 😉

@kaffein
Copy link
Member

kaffein commented Apr 26, 2020

A quick question related to the graphql-client. At the moment we are using react-appollo as the graphql client and I was wondering whether we would be interested in trying something new and more Clojure(script)-y.

I guess the choice for react-appollo was related to some features that the framework offered and that I am not aware of. That would be cool if you can give those requirements and maybe I can check if there are some clojurescript options that may cover those.

It seems that there are some very good options out there for graphql clients, for e.g : re-graph and graphql-query. I especially like the graphql-query approach which relies on data instead of having plain old string graphql query in re-graph.

@devth
Copy link
Member Author

devth commented Apr 26, 2020

Agree we should use something from CLJS-land. I didn’t have hard requirements on a client. It just seemed like a good option at the time for a React/JS app. So whatever you like!

@kaffein
Copy link
Member

kaffein commented Apr 26, 2020

cool thing 💯 !!! I am going to evaluate those options then and will let you know ^^

thanks

@kaffein
Copy link
Member

kaffein commented Jun 10, 2020

Things have been moving slowly forward on this side of our little world :)

At the moment, the functional implementation of the dashboard displaying yetibot statistics is complete. By functional, I mean the logic is there : we have a graphql client talking to our graphql endpoint, retrieving information and storing it in the local re-frame.db/app-db.

UI-wise, it is still a WIP since there are some little adjustments (pun intended :D) that need to be done, I have posted a small shot on the dev channel XD...

For the tech stack, as discussed previously :

  • we have introduced re-graph to be our graphql client.
  • we also introduced re-frame to play with reagent but also re-graph which provides some really cool stuff to work with.
  • at the moment, the graphql queries used with re-graph are plain text but at some point we

would like to introduce graphql-query which provides a more data-oriented approach to describing the graphql queries, which can be really cool since we would then have data all the way through.

PRs will be provided as soon as we have the UI fixed
I will keep you in the loop ^^

thanks :)

@devth
Copy link
Member Author

devth commented Jun 10, 2020

Awesome! Sounds like you got a lot of the hard stuff figured out.

graphql-query looks cool. Not super active on github, but that might be ok? 💯 on data-oriented 💪 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants