From 58eb896fba489919b6728bc85b9086cb9e6a3b06 Mon Sep 17 00:00:00 2001 From: Javier Rivero Iglesias Date: Sun, 26 Apr 2026 21:23:13 +0200 Subject: [PATCH 1/4] test: trigger semguard PR comment --- tests/fixtures/projects/base/models/orders.yml | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/tests/fixtures/projects/base/models/orders.yml b/tests/fixtures/projects/base/models/orders.yml index 320dce9..171669e 100644 --- a/tests/fixtures/projects/base/models/orders.yml +++ b/tests/fixtures/projects/base/models/orders.yml @@ -17,14 +17,11 @@ models: granularity: day dimension: type: time - - name: country - dimension: - type: categorical metrics: - name: gross_revenue label: Gross Revenue type: simple - agg: sum + agg: avg expr: order_total filter: order_status = 'completed' - name: order_count @@ -37,4 +34,4 @@ metrics: type: ratio label: Average order value numerator: gross_revenue - denominator: order_count + denominator: gross_revenue From 3ffb9d62819f0a948f5a04ed00da7a50767da49c Mon Sep 17 00:00:00 2001 From: Javier Rivero Iglesias Date: Sun, 26 Apr 2026 21:53:21 +0200 Subject: [PATCH 2/4] fix: update orders.yml to include additional fields and correct filters for metrics --- tests/fixtures/projects/base/models/orders.yml | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/tests/fixtures/projects/base/models/orders.yml b/tests/fixtures/projects/base/models/orders.yml index 171669e..77d1c7d 100644 --- a/tests/fixtures/projects/base/models/orders.yml +++ b/tests/fixtures/projects/base/models/orders.yml @@ -13,21 +13,33 @@ models: entity: name: customer type: foreign + - name: sales_rep_id + entity: + name: sales_rep + type: foreign - name: ordered_at granularity: day dimension: type: time + - name: sales_channel + dimension: + type: categorical metrics: - name: gross_revenue label: Gross Revenue type: simple agg: avg expr: order_total - filter: order_status = 'completed' + filter: order_status in ('completed', 'refunded') - name: order_count type: simple agg: count expr: 1 + - name: refunded_orders + type: simple + agg: count + expr: 1 + filter: order_status = 'refunded' metrics: - name: aov From 8d3ea864e2beea207644bc9dc215fae65d9fed69 Mon Sep 17 00:00:00 2001 From: Javier Rivero Iglesias Date: Sun, 26 Apr 2026 21:54:10 +0200 Subject: [PATCH 3/4] fix: change ordered_at granularity from day to week in orders.yml --- tests/fixtures/projects/base/models/orders.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/fixtures/projects/base/models/orders.yml b/tests/fixtures/projects/base/models/orders.yml index 77d1c7d..8fc8f84 100644 --- a/tests/fixtures/projects/base/models/orders.yml +++ b/tests/fixtures/projects/base/models/orders.yml @@ -18,7 +18,7 @@ models: name: sales_rep type: foreign - name: ordered_at - granularity: day + granularity: week dimension: type: time - name: sales_channel From ce127be06b988393d395d13490e4663395c4bfbb Mon Sep 17 00:00:00 2001 From: Javier Rivero Iglesias Date: Sun, 26 Apr 2026 22:07:36 +0200 Subject: [PATCH 4/4] fix: update pull-request permissions from read to write in semguard PR comment test workflow --- .github/workflows/semguard-pr-comment-test.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/semguard-pr-comment-test.yml b/.github/workflows/semguard-pr-comment-test.yml index 1ca4c4a..3dc74a6 100644 --- a/.github/workflows/semguard-pr-comment-test.yml +++ b/.github/workflows/semguard-pr-comment-test.yml @@ -9,7 +9,7 @@ on: permissions: contents: read issues: write - pull-requests: read + pull-requests: write checks: write jobs: