Merge branch 'master' into sql_null_params

Author: 1NepuNep1

.github/workflows/breaking.yml

@@ -10,6 +10,7 @@ jobs:
     concurrency:
       group: broken-changes-${{ github.ref }}
       cancel-in-progress: true
+    if: (!contains(github.event.pull_request.labels.*.name, 'broken changes'))
     runs-on: ubuntu-latest
     permissions: 
       pull-requests: write
@@ -24,11 +25,10 @@ jobs:
       - name: Install gorelease
         run: test -e ~/go/bin/gorelease || go install golang.org/x/exp/cmd/gorelease@latest
       - name: Check broken API changes
-        run: gorelease -base=$GITHUB_BASE_REF 2>&1 > changes.txt | true
-      - name: Print API changes
-        run: cat changes.txt
+        run: set -o pipefail && gorelease | tee changes.txt
+      # Skip comment for forks - GITHUB_TOKEN doesn't have write permissions for external PRs
       - name: Comment Report
-        if: always()
+        if: always() && github.event.pull_request.head.repo.full_name == github.repository
         uses: marocchino/sticky-pull-request-comment@v2
         with:
           path: changes.txt

.github/workflows/lint.yml

@@ -7,7 +7,7 @@ on:
   pull_request:
   workflow_dispatch:
 env:
-  GOLANGCI_LINT_VERSION: v2.1.6
+  GOLANGCI_LINT_VERSION: v2.4.0
   GO_VERSION: '1.25'
 jobs:
   golangci:

.golangci.yml

@@ -45,6 +45,10 @@ linters:
     - iface
     - gosmopolitan
     - funcorder
+
+    # introduced v2.4.0
+    - noinlineerr
+    - wsl_v5
   settings:
     errcheck:
       check-type-assertions: false
@@ -117,6 +121,10 @@ linters:
         - name: if-return
         - name: increment-decrement
         - name: var-naming
+          arguments:
+            - [] # AllowList
+            - [] # DenyList
+            - - skip-package-name-checks: true
         - name: var-declaration
         - name: package-comments
         - name: range

CHANGELOG.md

@@ -1,5 +1,14 @@
 * Supported `sql.Null*` from `database/sql` as query params in `toValue` func
 
+## v3.117.3
+* Added support for nullable `Date32`, `Datetime64`, `Timestamp64`, and `Interval64` types in the `optional` parameter builder
+* Added method `query.WithIssuesHandler` to get query issues
+
+## v3.117.2
+* Added support for `Result.RowsAffected()` for YDB `database/sql` driver
+* Upgraded minimal version of Go to 1.23.9
+* Fixed race in `readerReconnector`
+
 ## v3.117.1
 * Fixed scan a column of type `Decimal(precision,scale)` into a struct field of type `types.Decimal{}` using `ScanStruct()`
 * Fixed race in integration test `TestTopicWriterLogMessagesWithoutData`

README.md

@@ -3,8 +3,8 @@
 [![License](https://img.shields.io/badge/License-Apache%202.0-blue.svg)](https://github.com/ydb-platform/ydb/blob/main/LICENSE)
 [![Release](https://img.shields.io/github/v/release/ydb-platform/ydb-go-sdk.svg?style=flat-square)](https://github.com/ydb-platform/ydb-go-sdk/releases)
 [![PkgGoDev](https://pkg.go.dev/badge/github.com/ydb-platform/ydb-go-sdk/v3)](https://pkg.go.dev/github.com/ydb-platform/ydb-go-sdk/v3)
-![tests](https://github.com/ydb-platform/ydb-go-sdk/workflows/tests/badge.svg)
-![lint](https://github.com/ydb-platform/ydb-go-sdk/workflows/lint/badge.svg)
+[![tests](https://github.com/ydb-platform/ydb-go-sdk/workflows/tests/badge.svg)](https://github.com/ydb-platform/ydb-go-sdk/actions/workflows/tests.yml)
+[![lint](https://github.com/ydb-platform/ydb-go-sdk/workflows/lint/badge.svg)](https://github.com/ydb-platform/ydb-go-sdk/actions/workflows/lint.yml)
 [![Go Report Card](https://goreportcard.com/badge/github.com/ydb-platform/ydb-go-sdk/v3)](https://goreportcard.com/report/github.com/ydb-platform/ydb-go-sdk/v3)
 [![codecov](https://codecov.io/gh/ydb-platform/ydb-go-sdk/badge.svg?precision=2)](https://app.codecov.io/gh/ydb-platform/ydb-go-sdk)
 ![Code lines](https://sloc.xyz/github/ydb-platform/ydb-go-sdk/?category=code)
@@ -25,7 +25,7 @@ That is, the latest two versions of Go (or more, but with no guarantees for extr
 
 ## Versioning Policy
 
-`ydb-go-sdk` comply to guidelines from [SemVer2.0.0](https://semver.org/) with an several [exceptions](VERSIONING.md).
+`ydb-go-sdk` comply to guidelines from [SemVer2.0.0](https://semver.org/) with several [exceptions](VERSIONING.md).
 
 ## Installation
 

examples/go.mod

@@ -1,8 +1,6 @@
 module examples
 
-go 1.23.0
-
-toolchain go1.23.6
+go 1.23.9
 
 require (
 	github.com/apache/arrow/go/arrow v0.0.0-20211112161151-bc219186db40

examples/topic/topicreader/topicreader_handler.go

@@ -28,6 +28,7 @@ func StartReader(ctx context.Context, db *ydb.Driver) (*topiclistener.TopicListe
 
 type TopicEventsHandler struct {
 	topiclistener.BaseHandler
+
 	listener *topiclistener.TopicListener
 
 	m     sync.Mutex

go.mod

@@ -1,6 +1,6 @@
 module github.com/ydb-platform/ydb-go-sdk/v3
 
-go 1.22.5
+go 1.23.9
 
 require (
 	github.com/golang-jwt/jwt/v4 v4.5.2

internal/balancer/balancer.go

@@ -207,7 +207,7 @@ func (b *Balancer) applyDiscoveredEndpoints(ctx context.Context, newest []endpoi
 		)
 	}()
 
-	connections := endpointsToConnections(b.pool, newest)
+	connections := conn.EndpointsToConnections(b.pool, newest)
 	for _, c := range connections {
 		b.pool.Allow(ctx, c)
 		c.Endpoint().Touch()
@@ -453,12 +453,3 @@ func (b *Balancer) nextConn(ctx context.Context) (c conn.Conn, err error) {
 
 	return c, nil
 }
-
-func endpointsToConnections(p *conn.Pool, endpoints []endpoint.Endpoint) []conn.Conn {
-	conns := make([]conn.Conn, 0, len(endpoints))
-	for _, e := range endpoints {
-		conns = append(conns, p.Get(e))
-	}
-
-	return conns
-}

internal/balancer/balancer_test.go

@@ -14,6 +14,9 @@ import (
 	"google.golang.org/grpc/test/bufconn"
 
 	"github.com/ydb-platform/ydb-go-sdk/v3/config"
+	balancerConfig "github.com/ydb-platform/ydb-go-sdk/v3/internal/balancer/config"
+	"github.com/ydb-platform/ydb-go-sdk/v3/internal/conn"
+	"github.com/ydb-platform/ydb-go-sdk/v3/internal/endpoint"
 )
 
 func TestBalancer_discoveryConn(t *testing.T) {
@@ -71,6 +74,52 @@ func TestBalancer_discoveryConn(t *testing.T) {
 	require.NoError(t, err)
 }
 
+func TestApplyDiscoveredEndpoints(t *testing.T) {
+	ctx := context.Background()
+
+	cfg := config.New()
+	pool := conn.NewPool(ctx, cfg)
+	defer func() { _ = pool.Release(ctx) }()
+
+	b := &Balancer{
+		driverConfig:   cfg,
+		pool:           pool,
+		balancerConfig: balancerConfig.Config{},
+	}
+
+	initial := newConnectionsState(nil, b.balancerConfig.Filter, balancerConfig.Info{}, b.balancerConfig.AllowFallback)
+	b.connectionsState.Store(initial)
+
+	e1 := endpoint.New("e1.example:2135", endpoint.WithIPV6([]string{"2001:db8::1"}), endpoint.WithID(1))
+	e2 := endpoint.New("e2.example:2135", endpoint.WithIPV6([]string{"2001:db8::2"}), endpoint.WithID(2))
+
+	// call with two endpoints
+	b.applyDiscoveredEndpoints(ctx, []endpoint.Endpoint{e1, e2}, "")
+
+	// connectionsState should be updated and reflect the endpoints
+	after := b.connections()
+	require.NotNil(t, after)
+	all := after.All()
+	require.Equal(t, 2, len(all))
+	require.Equal(t, e1.Address(), all[0].Address())
+	require.Equal(t, e1.NodeID(), all[0].NodeID())
+	require.Equal(t, e2.Address(), all[1].Address())
+	require.Equal(t, e2.NodeID(), all[1].NodeID())
+
+	// partially replace endpoints
+	e3 := endpoint.New("e3.example:2135", endpoint.WithIPV6([]string{"2001:db8::3"}), endpoint.WithID(1))
+	b.applyDiscoveredEndpoints(ctx, []endpoint.Endpoint{e2, e3}, "")
+	// connectionsState should be updated and reflect the endpoints
+	after = b.connections()
+	require.NotNil(t, after)
+	all = after.All()
+	require.Equal(t, 2, len(all))
+	require.Equal(t, e2.Address(), all[0].Address())
+	require.Equal(t, e2.NodeID(), all[0].NodeID())
+	require.Equal(t, e3.Address(), all[1].Address())
+	require.Equal(t, e3.NodeID(), all[1].NodeID())
+}
+
 // Mock resolver
 //