Merge pull request #120 from duckzland/typo_breaks_create_new_elements

yassilah · web-flow · commit 0dd4d11c9586 · 2020-12-11T01:53:04.000+01:00
fix wrong placement of } causing failure to create new entries
diff --git a/src/NestedForm.php b/src/NestedForm.php
@@ -344,7 +344,7 @@ protected function fillAttributeFromRequest(NovaRequest $request, $requestAttrib
     {
         if ($model->exists) {
             $newRequest = NovaRequest::createFrom($request);
-            if (!$model->{$model->getKeyName() && $request->has($model->getKeyName())}) {
+            if (!$model->{$model->getKeyName()} && $request->has($model->getKeyName())) {
                 $model->{$model->getKeyName()} = $request->get($model->getKeyName());
             }
             $children = collect($newRequest->get($requestAttribute));

Original file line number	Diff line number	Diff line change
`@@ -344,7 +344,7 @@ protected function fillAttributeFromRequest(NovaRequest $request, $requestAttrib`
`344`	`344`	`{`
`345`	`345`	`if ($model->exists) {`
`346`	`346`	`$newRequest = NovaRequest::createFrom($request);`
`347`		`- if (!$model->{$model->getKeyName() && $request->has($model->getKeyName())}) {`
	`347`	`+ if (!$model->{$model->getKeyName()} && $request->has($model->getKeyName())) {`
`348`	`348`	`$model->{$model->getKeyName()} = $request->get($model->getKeyName());`
`349`	`349`	`}`
`350`	`350`	`$children = collect($newRequest->get($requestAttribute));`