Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GENERAL] Add Hide/Unhide password button #60

Closed
1 of 2 tasks
mohsenkhosroanjam opened this issue Jan 10, 2025 · 7 comments
Closed
1 of 2 tasks

[GENERAL] Add Hide/Unhide password button #60

mohsenkhosroanjam opened this issue Jan 10, 2025 · 7 comments
Assignees
Labels
Backend Related to the Backend part good first issue Good for newcomers Intermediate SWOC Level 2 issue SWOC officially part of SWOC season 5

Comments

@mohsenkhosroanjam
Copy link

mohsenkhosroanjam commented Jan 10, 2025

Category

Suggestion

Description

As a user, I can sign up to create an account. A Hide/Unhide button can be added to the password field. As a result, the users can press the button to unhide their entered password to ensure that they enter the password they want to set for their account. It can prevent users from making mistakes in setting their password.

Expected result:
Password is hidden by default and the button is in unhide state. When the user clicks on unhide button, the password should be unhidden and the button should be changed to hide state. In this situation, when user clicks on hide button, the password should be hidden and the button should be changed to unhide state.

Additional Context

1- Go to https://leetcode-journal.vercel.app/auth/register
Hide/Unhide button example: I found the example on https://www.codingnepalweb.com/show-hide-password-html-css-javascript/
image

Impact Level

Low

Contribution Guidelines

  • I have searched existing issues to avoid duplicates
  • I would like to help resolve this issue
Copy link

👋 Hello @mohsenkhosroanjam!

Thank you for raising an issue in the Leetcode Journal project!
Your issue has been logged, and the team will review it shortly.

Issue Handling Checklist:

  • Make sure the issue includes clear steps to reproduce (if applicable).
  • Provide relevant context, screenshots, or logs.
  • Mention if this issue blocks any critical workflows.

Notifications:

We'll get back to you soon. Stay tuned! 🚀

@yashksaini-coder yashksaini-coder added good first issue Good for newcomers SWOC officially part of SWOC season 5 Beginner SWOC Level 1 issue Up for Grabs The issue is open and up for grab labels Jan 10, 2025
@yashksaini-coder
Copy link
Owner

@mohsenkhosroanjam I see you have many issues are you planning to do all of them

@parthratra11
Copy link
Contributor

@yashksaini-coder i can add that, kindly assign it to me.

@momo-shogun
Copy link
Contributor

I can fix this issue please assign this to me

@yashksaini-coder
Copy link
Owner

@yashksaini-coder i can add that, kindly assign it to me.

You commented first so assigning it to you @parthratra11

@yashksaini-coder yashksaini-coder removed the Up for Grabs The issue is open and up for grab label Jan 11, 2025
@parthratra11
Copy link
Contributor

@yashksaini-coder added this feature and have raised a PR
It might have some conflict in the readme file, rest of the codebase is fine
Kindly look into it.

@yashksaini-coder yashksaini-coder changed the title [GENERAL] Add Hide/Unhide password button in sign up page [GENERAL] Add Hide/Unhide password button Jan 11, 2025
@yashksaini-coder yashksaini-coder added Intermediate SWOC Level 2 issue Backend Related to the Backend part and removed Beginner SWOC Level 1 issue labels Jan 11, 2025
@yashksaini-coder
Copy link
Owner

Already implemented

@yashksaini-coder yashksaini-coder closed this as not planned Won't fix, can't repro, duplicate, stale Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backend Related to the Backend part good first issue Good for newcomers Intermediate SWOC Level 2 issue SWOC officially part of SWOC season 5
Projects
None yet
Development

No branches or pull requests

4 participants