Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for ocaml-integers 0.3.0 #599

Closed
ygrek opened this issue Jun 13, 2019 · 3 comments
Closed

fix for ocaml-integers 0.3.0 #599

ygrek opened this issue Jun 13, 2019 · 3 comments

Comments

@ygrek
Copy link
Contributor

ygrek commented Jun 13, 2019

ocaml-integers 0.3.0 changed the name of C stubs library, ctypes manually links it in, so the corresponding change in needed. The following patch works, idk if it is too hacky or if it should be a configure check?

diff --git a/Makefile b/Makefile
index fe15a45..d239a28 100644
--- a/Makefile
+++ b/Makefile
@@ -67,7 +67,7 @@ ctypes.public = lDouble complexL ctypes posixTypes ctypes_types
 ctypes.dir = src/ctypes
 ctypes.extra_mls = ctypes_primitives.ml
 ctypes.deps = bigarray bytes integers
-ctypes.linkdeps = integers
+ctypes.linkdeps = integers_stubs
 ctypes.install = yes
 ctypes.install_native_objects = yes
 ifeq ($(XEN),enable)

ref yallop/ocaml-integers#26

@yallop
Copy link
Owner

yallop commented Jun 14, 2019

This looks sensible to me (but I haven't tested it yet). Could you turn it into a PR?

I don't think we should add a configure-time check, but we can change the opam constraint to be "integers" { < "0.3.0" }.

@yallop
Copy link
Owner

yallop commented Jun 14, 2019

Also, I expect this will eventually be made obsolete by @avsm's work in #588.

@ygrek
Copy link
Contributor Author

ygrek commented Jun 14, 2019

you meant "integers" >= "0.3.0" I guess

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants