Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: log level filter level doesn't reset when loading another file using drag and drop #133

Closed
Henry8192 opened this issue Nov 28, 2024 · 3 comments · Fixed by #141
Closed
Assignees
Labels
bug Something isn't working

Comments

@Henry8192
Copy link
Collaborator

Bug

Log level filter should reset the filter level when loading another file. However, on drag and drop a new file, the log level filter doesn't reset (and new logs are not filtered).

yscope-log-viewer version

82e677e

Environment

Chrome: 131.0.6778.86

Reproduction steps

  1. Open a new log file with log viewer.
  2. Set log level filter.
  3. Drag and drop another file, observe that the log level filter doesn't reset.
@Henry8192 Henry8192 added the bug Something isn't working label Nov 28, 2024
@junhaoliao
Copy link
Member

junhaoliao commented Nov 28, 2024

@Henry8192 thanks for catching this. In my opinion, this should either be fixed or documented.

@davemarco / @jackluo923 shall we persist the log level filter across different files?

@kirkrodrigues
Copy link
Member

should either be fixed

It needs to be fixed regardless since the logs are not filtered when the new file is loaded (even though the filter says it's enabled).

I would prefer we reset the filter when loading a new file.

@davemarco
Copy link
Contributor

I can fix this. Ill reset the filter per kirk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
4 participants