Skip to content

Commit fe6aaa3

Browse files
authored
Merge pull request #190 from sourcelair/contributing-md
Introduce CONTRIBUTING.md and Contributing section in README.md
2 parents 466dca3 + 6e6b527 commit fe6aaa3

File tree

3 files changed

+80
-3
lines changed

3 files changed

+80
-3
lines changed

.github/ISSUE_TEMPLATE.md

+11
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
<!-- Enter your issue description here -->
2+
3+
## Details
4+
- Browser and browser version:
5+
- OS version:
6+
- xterm.js version:
7+
8+
### Steps to reproduce
9+
10+
1.
11+
2.

CONTRIBUTING.md

+52
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,52 @@
1+
# How to contribute to xterm.js
2+
3+
- [Opening issues for bug reports or feature requests](#opening-issues)
4+
- [Contributing code](#contributing-code)
5+
6+
## Opening issues
7+
8+
The preferred way to report bugs or request features is to use
9+
[GitHub issues](http://github.com/sourcelair/xterm.js/issues). Before
10+
opening an issue, read these pointers.
11+
12+
### Opening issues effectively
13+
14+
- Include information about **the browser in which the problem occurred**. Even
15+
if you tested several browsers, and the problem occurred in all of them,
16+
mention this fact in the bug report. Also include browser version numbers and
17+
the operating system that you're on.
18+
19+
- Mention which release of xterm.js you're using. Preferably, try also with
20+
the current HEAD of the master branch, to ensure the problem has not already been
21+
fixed.
22+
23+
- Mention precisely what went wrong. What did you expect to happen? What happened instead? Describe the
24+
exact steps a maintainer has to take to make the problem occur.
25+
26+
- If the problem can not be reproduced in the [demo of xterm.js](README.md#demo), please provide an HTML document that demonstrates the problem.
27+
28+
- Be polite. Issues with an indignant or belligerent tone tend to be moved to the
29+
bottom of the pile.
30+
31+
## Contributing code
32+
33+
- Make sure you have a [GitHub account](https://github.com/join)
34+
- Fork [xterm.js](https://github.com/sourcelair/xterm.js/)
35+
([how to fork a repo](https://help.github.com/articles/fork-a-repo))
36+
- Make your changes
37+
- If your changes are easy to test or likely to regress, add tests. Tests go into `test`, directory.
38+
- Follow the general code style of the rest of the project (see below).
39+
- Submit a pull request
40+
([how to create a pull request](https://help.github.com/articles/fork-a-repo)).
41+
Don't put more than one feature/fix in a single pull request.
42+
43+
By contributing code to xterm.js you
44+
45+
- agree to license the contributed code under xterm.js' [MIT
46+
license](LICENSE).
47+
48+
- confirm that you have the right to contribute and license the code
49+
in question. (Either you hold all rights on the code, or the rights
50+
holder has explicitly granted the right to use it like this,
51+
through a compatible open source license or through a direct
52+
agreement with you.)

README.md

+17-3
Original file line numberDiff line numberDiff line change
@@ -51,11 +51,25 @@ var xterm = new Terminal();
5151
xterm.fit();
5252
```
5353

54-
## Contribution and License Agreement
54+
## Development and Contribution
5555

56-
If you contribute code to this project, you are implicitly allowing your code to be distributed under the MIT license. You are also implicitly verifying that all code is your original work.
56+
To contribute either code, documentation or issues to xterm.js please read the [Contributing document](CONTRIBUTING.md) before.
57+
58+
The development of xterm.js does not require any special tool. All you need is an editor that supports JavaScript and a browser (if you would like to run the demo you will need Node.js to get all features).
59+
60+
It is recommended though to use a development tool that uses xterm.js internally, to develop for xterm.js. [Eating our own dogfood](https://en.wikipedia.org/wiki/Eating_your_own_dog_food) has been proved extremely beneficial for this project. Known tools that use xterm.js internally are:
61+
62+
#### [SourceLair](https://www.sourcelair.com)
63+
64+
Visit https://lair.io/sourcelair/xterm and follow the instructions. All development will happen in your browser.
5765

58-
## License
66+
#### [Visual Studio Code](http://code.visualstudio.com/)
67+
68+
[Download Visual Studio Code](http://code.visualstudio.com/Download), clone xterm.js and you are all set.
69+
70+
## License Agreement
71+
72+
If you contribute code to this project, you are implicitly allowing your code to be distributed under the MIT license. You are also implicitly verifying that all code is your original work.
5973

6074
Copyright (c) 2014-2016, SourceLair, Private Company ([www.sourcelair.com](https://www.sourcelair.com/home)) (MIT License)
6175

0 commit comments

Comments
 (0)