130.0.1 (64-Bit)

[pitgas]

No longer works. The input field in the popup or new tab is empty, and the text is not transferred.
Fresh Firefox installation, no other add-ons installed.
Win 10; Fire Fox 130.0.1 (64-Bit)

[ltstereo]

same here Win 11 FF 130.0.1 (64-Bit)

[zznidar]

The problem appears to have been caused by DeepL changing the URL for translation.

Previously, passing #null/en caused it to auto-detect source language and translate to English. With the change, however, #null is not a valid language and causes the input to remain empty.

[xpmn]

I don't know what to put instead of null, tried some other variants, but it doesn't help

[no-one]

@xpmn This seems to be the language of the word that should be translated:
https://www.deepl.com/de/translator#en/de/hello
https://www.deepl.com/de/translator#de/es/hallo

[xpmn]

@no-one yes, I know, but previously I passed null to initiate autodetect. Now it stop working, so I've set to en just to make it at least not lost text

[nickzam]

Thank you for the prompt fix. Could you please upload update to Mozilla ?

[xpmn]

It's on review already

[jman-schief]

The old URL #null/de maybe was a hack? As far as I can see the web client now uses the same JSON payload as the official extension.

[xpmn]

yes it was ¯_(ツ)_/¯
but whole this extension is a hack

[nickzam]

FYI, I was tired of waiting for Firefox to review and installed it directly from github. It was much easier that I expected, cheers for the fix :)

[zznidar]

I am unable to check right now – but does language detection occur client-side or server-side? Because in the latter case, we could simply send a request to DeepL server, get the language in return, and only then open the URL with the correct languages.

[jman-schief]

I am unable to check right now – but does language detection occur client-side or server-side?

As far as I can see it's server side. This is what I see:

• I open https://www.deepl.com, the title of the input box says "Detect language" (so they don't yet know). They assume it's the one of my User-Agent (English in my case)
• I type "arm", the language detected is still English
• I type further "armu", the language detected now changes to German (they understand I want to translate "Armut")
• If I remove a letter and go back to "arm", language detected is back to English

Because in the latter case, we could simply send a request to DeepL server, get the language in return, and only then open the URL with the correct languages.

This extension allows to set a default language in the preferences, right? This setting could be used to set the default source language in the URL.