Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential performance issue: Unreliable performance of df.ewm in pandas 1.2.2 #849

Open
TendouArisu opened this issue Feb 16, 2025 · 1 comment

Comments

@TendouArisu
Copy link

Issue Description:

Hello.
I have discovered a performance degradation in the df.ewm function of pandas version 1.2.2 when ewm passed with times and it is so slow compared to ewm pased with int. And I notice that CI/requirements-wheel.txt, shows that it can depend on pandas version 1.2.2. I am not sure whether this performance problem in pandas will affect this repository. I found some discussions on GitHub related to this issue, including #39784 and #40072.
I also found that python/xorbits/_mars/dataframe/window/ewm/core.py used the influenced api. There may be more files used the influenced api.

Suggestion

I would recommend deleting the pandas 1.2.2 version.
Any other workarounds or solutions would be greatly appreciated.
Thank you!

@Dawnfz-Lenfeng
Copy link
Contributor

Thank you for raising this concern about the pandas 1.2.2 performance issue with df.ewm.

The latest versions of Xorbits typically only support and are tested against the most recent pandas releases. We recommend users to upgrade to the latest stable version of pandas when using Xorbits.

The performance issue you mentioned in pandas 1.2.2 has been fixed in newer pandas versions. Since Xorbits is actively maintained and updated to work with current pandas releases, this historical issue should not affect current Xorbits users.

If you're experiencing any performance issues, please make sure you're using the latest versions of both Xorbits and pandas.

Thanks again for bringing this to our attention!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants