feat(kernels): scaffold TVM FFI bidirectional interop test#202
feat(kernels): scaffold TVM FFI bidirectional interop test#202peter941221 wants to merge 2 commits into
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces TVM FFI bidirectional interoperability support to the pegainfer-kernels crate, adding the tvm-ffi dependency, a new tvm-ffi-interop feature, a C++ test fixture, and a comprehensive integration test. Feedback suggests removing the unnecessary cargo:rerun-if-changed directive for the test fixture in build.rs to prevent slow, redundant library rebuilds. Additionally, it is recommended to replace the login shell invocation (sh -lc) with a standard shell (sh -c) in the integration test to improve reliability and performance in CI/CD environments.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
This adds the first validation slice for #191 inside
pegainfer-kernels.The patch keeps TVM FFI behind a default-off
tvm-ffi-interopfeature, adds a small C++ fixture, and adds one ignored integration test that proves both call directions before any production FFI path changes.tvm-ffi = "0.1.0-alpha.0"topegainfer-kernelsand gate it behindtvm-ffi-interop.tests/fixtures/tvm_ffi_fixture.ccwith four exported functions that cover:tests/tvm_ffi_bidirectional.rsas an ignored integration test that builds the fixture at test runtime and verifies both call directions plus missing-symbol diagnostics.cargo fmt --all --checkcargo check --release -p pegainfer-kernels --features tvm-ffi-interop --tests -j 1cargo test --release -p pegainfer-kernels --features tvm-ffi-interop tvm_ffi_bidirectional -- --ignored --nocaptureRelated to #191.