also make sure 1 character length is invalid

xi-project · Nov 7, 2013 · 813ac09 · 813ac09
1 parent 5955d48
commit 813ac09
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 0 deletions.
diff --git a/library/Xi/Algorithm/Luhn.php b/library/Xi/Algorithm/Luhn.php
@@ -42,6 +42,10 @@ public function generate($number)
      */
     public function validate($number)
     {
+        if (strlen($number) < 2) {
+            return false;
+        }
+
         $original = substr($number, 0, strlen($number) - 1);
 
         return $this->generate($original) === $number;

diff --git a/tests/Xi/Tests/Algorithm/LuhnTest.php b/tests/Xi/Tests/Algorithm/LuhnTest.php
@@ -88,6 +88,7 @@ public function luhnInvalidProvider()
             array(799273983),
             array(1231),
             array(4565),
+            array(1),
         );
     }
 }