Skip to content

Commit ed0c832

Browse files
committed
Fix connection icon disappear bug
1 parent 4a44579 commit ed0c832

File tree

1 file changed

+13
-10
lines changed

1 file changed

+13
-10
lines changed

src/view/js/vue-components/app-pipelines.js

Lines changed: 13 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,7 @@ Vue.component('app-pipelines', {
108108
<td class="main-col">
109109
<div class="slds-truncate pipeline-name">
110110
<a v-on:click="openDetail(row.id)">{{ row.name }}</a><br />
111-
<p class="pipeline-desc slds-m-top_xx-small" v-if="(connectionmap[row.from] && connectionmap[row.to])">
111+
<p class="pipeline-desc slds-m-top_xx-small" v-if="connectionmap[row.from]">
112112
<i class="fab fa-github type-icon-small" v-if="connectionmap[row.from].type=='github'"></i>
113113
<i class="fab fa-bitbucket type-icon-small" v-if="connectionmap[row.from].type=='bitbucket'"></i>
114114
<span class="slds-icon_container slds-icon-utility-salesforce1 type-icon" v-if="connectionmap[row.from].type=='sfdc'">
@@ -121,16 +121,19 @@ Vue.component('app-pipelines', {
121121
<span v-if="row.type=='branch'">{{ row.branch.name }}</span>
122122
<span v-if="row.type=='commit'">#{{ (row.commits.length > 1) ? row.commits[0].sha.substr(0, 10) + '...' : row.commits[0].sha.substr(0, 10) }}</span>
123123
&nbsp;
124-
<i class="fas fa-arrow-right type-icon-small"></i>
125-
&nbsp;
126-
<i class="fab fa-github type-icon-small" v-if="connectionmap[row.to].type=='github'"></i>
127-
<i class="fab fa-bitbucket type-icon-small" v-if="connectionmap[row.to].type=='bitbucket'"></i>
128-
<span class="slds-icon_container slds-icon-utility-salesforce1 type-icon" v-if="connectionmap[row.to].type=='sfdc'">
129-
<svg class="slds-icon slds-icon_xx-small" aria-hidden="true">
130-
<use xlink:href="components/salesforce-lightning-design-system/assets/icons/utility-sprite/svg/symbols.svg#salesforce1"></use>
131-
</svg>
124+
<i class="fas fa-times type-icon-small" v-if="!connectionmap[row.to]"></i>
125+
<i class="fas fa-arrow-right type-icon-small" v-if="connectionmap[row.to]"></i>
126+
<span v-if="connectionmap[row.to]">
127+
&nbsp;
128+
<i class="fab fa-github type-icon-small" v-if="connectionmap[row.to].type=='github'"></i>
129+
<i class="fab fa-bitbucket type-icon-small" v-if="connectionmap[row.to].type=='bitbucket'"></i>
130+
<span class="slds-icon_container slds-icon-utility-salesforce1 type-icon" v-if="connectionmap[row.to].type=='sfdc'">
131+
<svg class="slds-icon slds-icon_xx-small" aria-hidden="true">
132+
<use xlink:href="components/salesforce-lightning-design-system/assets/icons/utility-sprite/svg/symbols.svg#salesforce1"></use>
133+
</svg>
134+
</span>
135+
{{ connectionmap[row.to].name }}
132136
</span>
133-
{{ connectionmap[row.to].name }}
134137
</p><!-- .pipeline-desc -->
135138
</div>
136139
</td>

0 commit comments

Comments
 (0)