Skip to content

Update native snappy VERSION to 1.2.2 #662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
findmenowhere wants to merge 4 commits into from
Closed

Update native snappy VERSION to 1.2.2 #662

findmenowhere wants to merge 4 commits into from

Conversation

@findmenowhere
Copy link

@findmenowhere findmenowhere commented May 8, 2025 •
edited
Loading

update native snappy to 1.2.1

@findmenowhere
Copy link
Author

findmenowhere commented May 20, 2025

@xerial
Build native failed because Google Benchmark submodule requires a minimum CMake version of 3.16.3. However, the multi-arch Docker image is based on Debian Stretch (8), which bundles CMake 3.7.2.
There’s an open PR updating the base image to Debian 11 (Bullseye) (multiarch/crossbuild#61), but it’s been pending for over four years. Could we use a different patched version of the crossbuild Docker image?

@findmenowhere
Copy link
Author

findmenowhere commented May 27, 2025

Hello @xerial , could you take a look of the change?

@xerial xerial changed the title Update native snappy VERSION Update native snappy VERSION to 1.2.2 Jul 19, 2025
xerial added a commit that referenced this pull request Jul 19, 2025
@xerial @claude
Update Snappy version to 1.2.2 and fix test compatibility
ddc8fb4 
- Update SNAPPY_VERSION from 1.1.10 to 1.2.2 in VERSION file
- Fix SnappyOutputStreamTest expected compression size for aarch64
  (90277 bytes) to match improved compression ratio in Snappy 1.2.2
- All tests pass with new version

Fixes #662

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>
@xerial
Copy link
Owner

xerial commented Jul 19, 2025

hmm. It seems CMake 3.10 is required in the build image

@xerial xerial closed this in 6d25a37 Jul 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@findmenowhere @xerial