Rewrite bin/test to byte-compile before running and clean stale .elc

Adds dependency validation, .elc cleanup across all load-path roots,
scratch file filtering, and configurable acp_root/shell_maker_root
with sensible sibling-worktree defaults.

Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>

Author: timvisher-dd

bin/test

@@ -1,21 +1,79 @@
-#!/usr/bin/env bash
-set -euo pipefail
+#!/usr/bin/env bash -O globstar -O extglob
 
-root="$(cd "$(dirname "$0")/.." && pwd)"
+# Assume that acp.el and shell-maker are checked out in sibling trunk
+# worktrees and allow their location to be overridden:
+# …/agent-shell/main/bin/test
+# …/acp.el/main
+# …/shell-maker/main
+root=$(dirname "$0")/..
+tests_dir=${root}/tests
+acp_root=${acp_root:-${root}/../../acp.el/main}
+shell_maker_root=${shell_maker_root:-${root}/../../shell-maker/main}
 
-: "${shell_maker_checkout:?Set shell_maker_checkout to your shell-maker checkout (e.g. ~/git/xenodium/shell-maker/main)}"
-: "${acp_checkout:?Set acp_checkout to your acp.el checkout (e.g. ~/git/timvisher-dd/acp.el/dev)}"
+if ! [[ -r ${acp_root}/acp.el ]]
+then
+  echo "Set shell_maker_root to your shell-maker checkout (e.g. ~/git/xenodium/shell-maker/main)" >&2
+  die=1
+fi
 
-test_files=()
-for f in "$root"/tests/*-tests.el; do
-  test_files+=(-l "$f")
+if ! [[ -r ${shell_maker_root}/shell-maker.el ]]
+then
+  echo "Set shell_maker_root to your shell-maker checkout (e.g. ~/git/xenodium/shell-maker/main)" >&2
+  die=1
+fi
+
+if [[ -n $die ]]
+then
+  echo "Fix the ↑ problems" >&2
+  exit 1
+fi
+
+shopt -s nullglob
+all_elc_files=({"${root}","${acp_root}","${shell_maker_root}"}/**/*.elc)
+all_el_files=("${root}"/*.el)
+test_files=("${tests_dir}"/*-tests.el)
+shopt -u nullglob
+
+if (( 0 < ${#all_elc_files[@]} ))
+then
+  rm -v "${all_elc_files[@]}"
+fi
+
+# Filter out x./y./z. prefixed scratch files from compilation
+compile_files=()
+for f in "${all_el_files[@]}"; do
+  case "$(basename "$f")" in
+    x.*|y.*|z.*) ;;
+    *) compile_files+=("$f") ;;
+  esac
 done
 
-exec emacs --batch -Q \
-  --eval "(setq load-prefer-newer 't)" \
-  -L "$root" \
-  -L "$root/tests" \
-  -L "$shell_maker_checkout" \
-  -L "$acp_checkout" \
-  "${test_files[@]}" \
+if (( ${#compile_files[@]} < 1 )); then
+  echo "No compile targets found in ${root}" >&2
+  exit 1
+fi
+
+if (( ${#test_files[@]} < 1 )); then
+  echo "No test files found in ${tests_dir}" >&2
+  exit 1
+fi
+
+test_args=()
+for file in "${test_files[@]}"; do
+  test_args+=(-l "$file")
+done
+
+emacs -Q --batch \
+  -L "${root}" \
+  -L "${acp_root}" \
+  -L "${shell_maker_root}" \
+  -f batch-byte-compile \
+  "${compile_files[@]}"
+
+emacs -Q --batch \
+  -L "${root}" \
+  -L "${acp_root}" \
+  -L "${shell_maker_root}" \
+  -L "${tests_dir}" \
+  "${test_args[@]}" \
   -f ert-run-tests-batch-and-exit