Improper Gain Evaluation

[hawkofsky]

XVA-06M: Improper Gain Evaluation

Type	Severity	Location
Logical Fault	Medium	xVault.sol:L608

Description:

The gain of the strategy does not factor the loss nor the performance fees applied to the gains.

Example:

if (loss > 0) {
  _reportLoss(msg.sender, loss);
}

_assessFees(msg.sender, gain);

strategies[msg.sender].totalGain = strategies[msg.sender].totalGain.add(gain);

Recommendation:

We advise this to be done so to avoid miscalculated APYs and general metrics in the codebase.

[hawkofsky]

I can't understand what it does mean.

[hawkofsky]

totalGain and totalLoss of Strategy represents the total returns/losses the Strategy has realized, They are for show, i.e how much the strategy is effective. It doesn't represent how exactly users are getting profited. So shouldn't apply fee.
It's not used for calculating the apy, etc.