Skip to content

Commit c0e96aa

Browse files
committed
Rename create_materialized_view argument index to more descriptive concurrent_index
1 parent 941d521 commit c0e96aa

File tree

2 files changed

+7
-5
lines changed

2 files changed

+7
-5
lines changed

django_pgviews/models.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ def run_backlog(self, backlog, *, force, update, materialized_views_check_sql_ch
7171
connection,
7272
view_cls._meta.db_table,
7373
view_cls.get_sql(),
74-
index=view_cls._concurrent_index,
74+
concurrent_index=view_cls._concurrent_index,
7575
with_data=view_cls.with_data,
7676
check_sql_changed=materialized_views_check_sql_changed,
7777
)

django_pgviews/view.py

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@ def _drop_mat_view(cursor, view_name):
9797

9898
@transaction.atomic()
9999
def create_materialized_view(
100-
connection, view_name, view_query: ViewSQL, index=None, with_data=True, check_sql_changed=False
100+
connection, view_name, view_query: ViewSQL, concurrent_index=None, with_data=True, check_sql_changed=False
101101
):
102102
"""
103103
Create a materialized view on a connection.
@@ -148,9 +148,11 @@ def create_materialized_view(
148148
_drop_mat_view(cursor, view_name)
149149

150150
_create_mat_view(cursor, view_name, query, view_query.params, with_data=with_data)
151-
if index is not None:
152-
index_sub_name = "_".join([s.strip() for s in index.split(",")])
153-
cursor.execute("CREATE UNIQUE INDEX {0}_{1}_index ON {0} ({2})".format(view_name, index_sub_name, index))
151+
if concurrent_index is not None:
152+
index_sub_name = "_".join([s.strip() for s in concurrent_index.split(",")])
153+
cursor.execute(
154+
"CREATE UNIQUE INDEX {0}_{1}_index ON {0} ({2})".format(view_name, index_sub_name, concurrent_index)
155+
)
154156

155157
if view_exists:
156158
return "UPDATED"

0 commit comments

Comments
 (0)