Skip to content

Commit eea4baf

Browse files
committed
redis-test is now a better Redis citizen, testing everything against DB 9 and 10 and only if this DBs are empty.
1 parent 121796f commit eea4baf

File tree

1 file changed

+44
-21
lines changed

1 file changed

+44
-21
lines changed

test-redis.tcl

+44-21
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,7 @@ proc zlistAlikeSort {a b} {
4747

4848
proc main {server port} {
4949
set r [redis $server $port]
50+
$r select 9
5051
set err ""
5152

5253
# The following AUTH test should be enabled only when requirepass
@@ -312,47 +313,47 @@ proc main {server port} {
312313
} {0}
313314

314315
test {DEL all keys again (DB 1)} {
315-
$r select 1
316+
$r select 10
316317
foreach key [$r keys *] {
317318
$r del $key
318319
}
319320
set res [$r dbsize]
320-
$r select 0
321+
$r select 9
321322
format $res
322323
} {0}
323324

324325
test {MOVE basic usage} {
325326
$r set mykey foobar
326-
$r move mykey 1
327+
$r move mykey 10
327328
set res {}
328329
lappend res [$r exists mykey]
329330
lappend res [$r dbsize]
330-
$r select 1
331+
$r select 10
331332
lappend res [$r get mykey]
332333
lappend res [$r dbsize]
333-
$r select 0
334+
$r select 9
334335
format $res
335336
} [list 0 0 foobar 1]
336337

337338
test {MOVE against key existing in the target DB} {
338339
$r set mykey hello
339-
$r move mykey 1
340+
$r move mykey 10
340341
} {0}
341342

342343
test {SET/GET keys in different DBs} {
343344
$r set a hello
344345
$r set b world
345-
$r select 1
346+
$r select 10
346347
$r set a foo
347348
$r set b bared
348-
$r select 0
349+
$r select 9
349350
set res {}
350351
lappend res [$r get a]
351352
lappend res [$r get b]
352-
$r select 1
353+
$r select 10
353354
lappend res [$r get a]
354355
lappend res [$r get b]
355-
$r select 0
356+
$r select 9
356357
format $res
357358
} {hello world foo bared}
358359

@@ -618,7 +619,7 @@ proc main {server port} {
618619
} [lsort -real {1.1 5.10 3.10 7.44 2.1 5.75 6.12 0.25 1.15}]
619620

620621
test {LREM, remove all the occurrences} {
621-
$r flushall
622+
$r flushdb
622623
$r rpush mylist foo
623624
$r rpush mylist bar
624625
$r rpush mylist foobar
@@ -642,7 +643,7 @@ proc main {server port} {
642643
} {{foobar foobared zap test foo} 0}
643644

644645
test {LREM, starting from tail with negative count} {
645-
$r flushall
646+
$r flushdb
646647
$r rpush mylist foo
647648
$r rpush mylist bar
648649
$r rpush mylist foobar
@@ -670,7 +671,7 @@ proc main {server port} {
670671
} {2}
671672

672673
test {MGET} {
673-
$r flushall
674+
$r flushdb
674675
$r set foo BAR
675676
$r set bar FOO
676677
$r mget foo bar
@@ -687,7 +688,7 @@ proc main {server port} {
687688
} {BAR {} FOO {}}
688689

689690
test {RANDOMKEY} {
690-
$r flushall
691+
$r flushdb
691692
$r set foo x
692693
$r set bar y
693694
set foo_seen 0
@@ -705,12 +706,12 @@ proc main {server port} {
705706
} {1 1}
706707

707708
test {RANDOMKEY against empty DB} {
708-
$r flushall
709+
$r flushdb
709710
$r randomkey
710711
} {}
711712

712713
test {RANDOMKEY regression 1} {
713-
$r flushall
714+
$r flushdb
714715
$r set x 10
715716
$r del x
716717
$r randomkey
@@ -889,10 +890,15 @@ proc main {server port} {
889890
}
890891

891892
# Leave the user with a clean DB before to exit
892-
test {FLUSHALL} {
893-
$r flushall
894-
$r dbsize
895-
} {0}
893+
test {FLUSHDB} {
894+
set aux {}
895+
$r select 9
896+
$r flushdb
897+
lappend aux [$r dbsize]
898+
$r select 10
899+
$r flushdb
900+
lappend aux [$r dbsize]
901+
} {0 0}
896902

897903
puts "\n[expr $::passed+$::failed] tests, $::passed passed, $::failed failed"
898904
if {$::failed > 0} {
@@ -903,7 +909,8 @@ proc main {server port} {
903909

904910
proc stress {} {
905911
set r [redis]
906-
$r flushall
912+
$r select 9
913+
$r flushdb
907914
while 1 {
908915
set randkey [expr int(rand()*10000)]
909916
set randval [expr int(rand()*10000)]
@@ -924,9 +931,25 @@ proc stress {} {
924931
}
925932
flush stdout
926933
}
934+
$r flushdb
927935
$r close
928936
}
929937

938+
# Before to run the test check if DB 9 and DB 10 are empty
939+
set r [redis]
940+
$r select 9
941+
set db9size [$r dbsize]
942+
$r select 10
943+
set db10size [$r dbsize]
944+
if {$db9size != 0 || $db10size != 0} {
945+
puts "Can't run the tests against DB 9 and 10: DBs are not empty."
946+
exit 1
947+
}
948+
$r close
949+
unset r
950+
unset db9size
951+
unset db10size
952+
930953
if {[llength $argv] == 0} {
931954
main 127.0.0.1 6379
932955
} elseif {[llength $argv] == 1 && [lindex $argv 0] eq {stress}} {

0 commit comments

Comments
 (0)