Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 244 needs further investigation #267

Closed
dilijev opened this issue May 15, 2013 · 1 comment
Closed

Issue 244 needs further investigation #267

dilijev opened this issue May 15, 2013 · 1 comment

Comments

@dilijev
Copy link
Collaborator

dilijev commented May 15, 2013

I have verified that, at least on the Unicode version of wxMaxima, #244 doesn't seem to be working.

The issue seems to be related to the ordering of statements in wxMaxima::GetDefaultEntry.

In particular, it appears that the expression "m_console->CanCopy(true)" is true in all the cases I would have expected "m_console->GetActiveCell() != NULL" to be true, and that branch is being executed while ignoring ExtractFirstExpression.

What was the intent behind that code block -- why are these conditionals considered different cases? I don't believe I added the check for CanCopy, but has the definition of that function changed recently?

Since I can't reopen that issue, I've created this new one.

@dilijev
Copy link
Collaborator Author

dilijev commented Jul 19, 2013

Moved this comment into the re-opened #244.

@dilijev dilijev closed this as completed Jul 19, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant