General Math buttons copy expressions with semicolons (reopened)

[dilijev]

When the cursor is in a cell (no selection) and "Simplify" is selected from General Math, the expression is copied with its semicolon. Since the semicolon is syntactically incorrect in the current context, the simplification fails, and the expression must be corrected manually.

I suggest stripping out the semicolon before copying the cell's text. If a cell contains multiple statements, call the math function once for each input, separating the inputs by the semicolons.

[dilijev]

Reported in #243 by benibela.

I have verified existence of bug on Windows in wxMaxima 12.01.

[dilijev]

I have verified that, at least on the Unicode version of wxMaxima, #244 doesn't seem to be working.

The issue seems to be related to the ordering of statements in wxMaxima::GetDefaultEntry.

In particular, it appears that the expression "m_console->CanCopy(true)" is true in all the cases I would have expected "m_console->GetActiveCell() != NULL" to be true, and that branch is being executed while ignoring ExtractFirstExpression.

What was the intent behind that code block -- why are these conditionals considered different cases? I don't believe I added the check for CanCopy, but has the definition of that function changed recently?