Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weighted standard deviation of AGS #198

Open
TlaskalV opened this issue Oct 24, 2024 · 2 comments
Open

Weighted standard deviation of AGS #198

TlaskalV opened this issue Oct 24, 2024 · 2 comments

Comments

@TlaskalV
Copy link

Hi Ben,
I am running microbial_fraction with few metagenomes and it is great. I was thinking that it should be possible to include the weighted standard deviation of the average genome size in the calculation below, right? This would help to get an idea of the variance in genome sizes.

average_genome_size = average_genome_size_numerator / average_genome_size_denominator

Thank you for considering such feature.

Cheers,
Vojtech

@wwood
Copy link
Owner

wwood commented Oct 24, 2024

Thanks for the suggestion @TlaskalV

We had considered this, but there's a few negatives to this approach. The main thing is that genome size changes are just one of the uncertainties. Another is the coverage of each lineage in the profile, or uncertainty in the taxonomic assignments.

Having uncertainty measures just from genome sizes could therefore be a bit misleading to the user, if you follow?

Thanks, ben

@TlaskalV
Copy link
Author

Thanks for taking the time to review my suggestion and explaining your reasoning. While I still lean toward the variance idea, I get where you're coming from - looking forward to continuing to use the microbial_fraction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants