-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add fallback for screen comparator with selector #100
Comments
Is that really helpful to have a screenshot of another area than we actually wanted? |
Yes. The current situation is cery confusing. Domek people think that AET
crashed when they see this error.
I would prefer to have error AND screenshot as IT makes debugging quicker.
What happenened? Did page bot open? Was the element there but bot fully
loaded? Was there a loader displayed?
Currently debugging the issue od bot do straightforward, especially since
AET are often needed for quick feedback (eg during release) without enough
time to investigate everything.
In some places we ditched this functionality quickly and decided to use
hides instead.
|
A smaller improvement to consider: even if the test fails, let's display the pattern. Currently the pattern is not displayed, just the error message. Pattern would make it easy to see what was supposed to be tested and what should I retest by hand. |
it looks like the issue will be addressed as a part of #134 |
When I use
and the overlay fails to open then I receive a "Processing error" that indicates that AET were unable to take the screenshot.
It would be useful to have a fallback: if screen with selector fails, then simply take a screenshot of whole page (it would be simpler to debug the issue by a not experienced QA)
The text was updated successfully, but these errors were encountered: