Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fallback for screen comparator with selector #100

Open
bamanczak opened this issue May 15, 2017 · 4 comments
Open

Add fallback for screen comparator with selector #100

bamanczak opened this issue May 15, 2017 · 4 comments

Comments

@bamanczak
Copy link

When I use

<open/>
<click xpath="selector-to-a-button-that-opens-an-overlay" timeout="5000"/>
<screen name="Desktop" css'"selector-to-an-overlay"/>

and the overlay fails to open then I receive a "Processing error" that indicates that AET were unable to take the screenshot.

It would be useful to have a fallback: if screen with selector fails, then simply take a screenshot of whole page (it would be simpler to debug the issue by a not experienced QA)

@malaskowski
Copy link
Contributor

Is that really helpful to have a screenshot of another area than we actually wanted?
I think this is rather confusing unless e.g. we always say that in such case the 'collection' has ERROR status.

@bamanczak
Copy link
Author

bamanczak commented May 25, 2017 via email

@bamanczak
Copy link
Author

A smaller improvement to consider: even if the test fails, let's display the pattern. Currently the pattern is not displayed, just the error message.

Pattern would make it easy to see what was supposed to be tested and what should I retest by hand.

@radeklawgmin
Copy link
Contributor

radeklawgmin commented Jul 11, 2017

it looks like the issue will be addressed as a part of #134

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants