Send email notification upon scan completion#158
Open
mathuriga wants to merge 4 commits intowso2:masterfrom
Open
Send email notification upon scan completion#158mathuriga wants to merge 4 commits intowso2:masterfrom
mathuriga wants to merge 4 commits intowso2:masterfrom
Conversation
mathuriga
changed the title
Member
|
Can we reuse the GmailApiUtil for this purpose? @mathuriga |
Member
|
Ok.. I think this PR was sent way before the Util was created. Approving this for now. Let's create a GitHub issue for future improvment |
ayomawdb
approved these changes
Sep 7, 2020
Member
|
@mathuriga please check travis also before proceeding |
Member
|
@mathuriga Please check on the conflicts |
ayomawdb
reviewed
Nov 20, 2020
| margin-bottom: 15px; | ||
| margin-top: 15px; | ||
|
|
||
| } No newline at end of file |
|
|
||
| @Override | ||
| public boolean clearScan(String id) { | ||
| @Override public boolean clearScan(String id) { |
Member
There was a problem hiding this comment.
Suggested change
| @Override public boolean clearScan(String id) { | |
| @Override | |
| public boolean clearScan(String id) { |
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This PR adds send an email notification upon scan completions feature. In addition to this, filtering view scans based on product name also incorporated.
Goals
Send email notification upon scan completion
Filter scan based on product name
User stories
N/A
Release note
N/A
Documentation
N/A
Training
N/A
Certification
N/A
Marketing
N/A
Automation tests
N/A
N/A
Security checks
Samples
N/A
Related PRs
N/A
Migrations (if applicable)
N/A
Test environment
N/A
Learning
N/A