Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RabbitMQ publisher confirms #3834

Open
ruwanmadhusanka opened this issue Dec 16, 2024 · 5 comments
Open

RabbitMQ publisher confirms #3834

ruwanmadhusanka opened this issue Dec 16, 2024 · 5 comments

Comments

@ruwanmadhusanka
Copy link

Problem

If messages being sent to RabbitMQ are lost or dropped, we are unable to identify that they have been dropped.

Proposed Solution

Publisher confirms [1] in rebbitMQ which can be a facilitated mechanism to ensure reliability when publishing messages to a RabbitMQ exchange.
It would be better if we could get this feature in Micro Integrator.

[1] https://www.rabbitmq.com/docs/confirms#publisher-confirms

Alternatives

No response

Version

No response

@alienfs
Copy link

alienfs commented Dec 16, 2024

Please refer to https://jack-vanlightly.com/blog/2018/9/10/how-to-lose-messages-on-a-rabbitmq-cluster as to why this feature is needed.

@sajhak
Copy link

sajhak commented Jan 7, 2025

@ruwanmadhusanka https://github.com/wso2/wso2-axis2-transports/blob/v2.0.0-wso2v65/modules/rabbitmq/src/main/java/org/apache/axis2/transport/rabbitmq/RabbitMQConstants.java#L97 gives an indication that this is already supported. Please double check the validity of this issue.

@alienfs
Copy link

alienfs commented Jan 14, 2025

In DRGSUB-197 it was discovered that this functionality already exists via the, currently still undocumented, property rabbitmq.publisher.confirms.enabled.

@ruwanmadhusanka
Copy link
Author

Hi @alienfs , @sajhak

The documentation has already been updated. Please find the documentation[1] for more details.

[1] https://mi.docs.wso2.com/en/4.2.0/reference/synapse-properties/transport-parameters/rabbitmq-transport-parameters/#other-parameters-optional

Thanks & Regards.

@alienfs
Copy link

alienfs commented Jan 14, 2025

Hi @ruwanmadhusanka:

I see it is also written here:
https://apim.docs.wso2.com/en/4.1.0/reference/synapse-properties/transport-parameters/rabbitmq-transport-parameters/

I would suggest stating that the property is a boolean and thus requires a "true" or "false" value.

Regardless, this issue should be closed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants