Skip to content

Commit 5f1d071

Browse files
committed
Renamed global variables
1 parent 0effdfe commit 5f1d071

File tree

4 files changed

+40
-26
lines changed

4 files changed

+40
-26
lines changed

.gitignore

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
tmp/*
22
wsjcpp-core
3+
.vscode/*
4+
*.log
35

46
# Prerequisites
57
*.d

src/main.cpp

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,16 @@ int main(int argc, char* argv[]) {
77
std::string TAG = "MAIN";
88
std::string appName = std::string(WSJCPP_NAME);
99
std::string appVersion = std::string(WSJCPP_VERSION);
10+
WSJCppLog::setPrefixLogFile("wsjcpp_core");
11+
WSJCppLog::info(TAG, "Hello");
1012

11-
// TODO
12-
13+
WSJCppCore::init(
14+
argc, argv,
15+
std::string(WSJCPP_NAME),
16+
std::string(WSJCPP_VERSION),
17+
"Evgenii Sopov",
18+
""
19+
);
20+
1321
return 0;
1422
}

src/wsjcpp_core.cpp

Lines changed: 22 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -380,21 +380,23 @@ std::string WSJCppCore::createUuid() {
380380
// WSJCppLog
381381

382382
// Last log messages
383-
std::deque<std::string> *g_LAST_LOG_MESSAGES = NULL;
384-
std::mutex *g_LOG_MUTEX = NULL;
385-
std::string WSJCppLog::g_LOG_DIR = "./";
386-
std::string WSJCppLog::g_LOG_FILE = "";
387-
std::string WSJCppLog::g_PREFIX_LOG_FILE = "";
388-
long WSJCppLog::g_LOG_START_TIME = 0;
383+
std::deque<std::string> * WSJCppLog::g_WSJCPP_LOG_LAST_MESSAGES = nullptr;
384+
std::mutex * WSJCppLog::g_WSJCPP_LOG_MUTEX = nullptr;
385+
std::string WSJCppLog::g_WSJCPP_LOG_DIR = "./";
386+
std::string WSJCppLog::g_WSJCPP_LOG_FILE = "";
387+
std::string WSJCppLog::g_WSJCPP_LOG_PREFIX_FILE = "";
388+
long WSJCppLog::g_WSJCPP_LOG_START_TIME = 0;
389389

390390
// ---------------------------------------------------------------------
391391

392392
void WSJCppLog::doLogRotateUpdateFilename(bool bForce) {
393393
long t = WSJCppCore::currentTime_seconds();
394394
long nEverySeconds = 51000; // rotate log if started now or if time left more then 1 day
395-
if (g_LOG_START_TIME == 0 || t - g_LOG_START_TIME > nEverySeconds || bForce) {
396-
g_LOG_START_TIME = t;
397-
g_LOG_FILE = g_LOG_DIR + "/" + WSJCppLog::g_PREFIX_LOG_FILE + "_" + WSJCppCore::formatTimeForFilename(g_LOG_START_TIME) + ".log";
395+
if (g_WSJCPP_LOG_START_TIME == 0 || t - g_WSJCPP_LOG_START_TIME > nEverySeconds || bForce) {
396+
g_WSJCPP_LOG_START_TIME = t;
397+
g_WSJCPP_LOG_FILE = g_WSJCPP_LOG_DIR + "/"
398+
+ WSJCppLog::g_WSJCPP_LOG_PREFIX_FILE + "_"
399+
+ WSJCppCore::formatTimeForFilename(g_WSJCPP_LOG_START_TIME) + ".log";
398400
}
399401
}
400402

@@ -437,28 +439,28 @@ void WSJCppLog::ok(const std::string &sTag, const std::string &sMessage) {
437439
// ---------------------------------------------------------------------
438440

439441
void WSJCppLog::setLogDirectory(const std::string &sDirectoryPath) {
440-
WSJCppLog::g_LOG_DIR = sDirectoryPath;
442+
WSJCppLog::g_WSJCPP_LOG_DIR = sDirectoryPath;
441443
WSJCppLog::doLogRotateUpdateFilename(true);
442444
}
443445

444446
// ---------------------------------------------------------------------
445447

446448
void WSJCppLog::setPrefixLogFile(const std::string &sPrefixLogFile) {
447-
WSJCppLog::g_PREFIX_LOG_FILE = sPrefixLogFile;
449+
WSJCppLog::g_WSJCPP_LOG_PREFIX_FILE = sPrefixLogFile;
448450
WSJCppLog::doLogRotateUpdateFilename(true);
449451
}
450452

451453
// ---------------------------------------------------------------------
452454

453455
void WSJCppLog::initGlobalVariables() {
454456
// create deque if not created
455-
if (g_LAST_LOG_MESSAGES == NULL) {
456-
g_LAST_LOG_MESSAGES = new std::deque<std::string>();
457+
if (WSJCppLog::g_WSJCPP_LOG_LAST_MESSAGES == nullptr) {
458+
WSJCppLog::g_WSJCPP_LOG_LAST_MESSAGES = new std::deque<std::string>();
457459
// std::cout << WSJCppCore::currentTime_logformat() + ", " + WSJCppCore::threadId() + " Init last messages deque\r\n";
458460
}
459461
// create mutex if not created
460-
if (g_LOG_MUTEX == NULL) {
461-
g_LOG_MUTEX = new std::mutex();
462+
if (WSJCppLog::g_WSJCPP_LOG_MUTEX == nullptr) {
463+
WSJCppLog::g_WSJCPP_LOG_MUTEX = new std::mutex();
462464
// std::cout << WSJCppCore::currentTime_logformat() + ", " + WSJCppCore::threadId() + " Init mutex for log\r\n";
463465
}
464466
}
@@ -469,19 +471,19 @@ void WSJCppLog::add(WSJCppColorModifier &clr, const std::string &sType, const st
469471
WSJCppLog::initGlobalVariables();
470472
WSJCppLog::doLogRotateUpdateFilename();
471473

472-
std::lock_guard<std::mutex> lock(*g_LOG_MUTEX);
474+
std::lock_guard<std::mutex> lock(*WSJCppLog::g_WSJCPP_LOG_MUTEX);
473475
WSJCppColorModifier def(WSJCppColorCode::FG_DEFAULT);
474476

475477
std::string sLogMessage = WSJCppCore::currentTime_logformat() + ", " + WSJCppCore::threadId()
476478
+ " [" + sType + "] " + sTag + ": " + sMessage;
477479
std::cout << clr << sLogMessage << def << std::endl;
478480

479-
g_LAST_LOG_MESSAGES->push_front(sLogMessage);
480-
while (g_LAST_LOG_MESSAGES->size() > 50) {
481-
g_LAST_LOG_MESSAGES->pop_back();
481+
g_WSJCPP_LOG_LAST_MESSAGES->push_front(sLogMessage);
482+
while (g_WSJCPP_LOG_LAST_MESSAGES->size() > 50) {
483+
g_WSJCPP_LOG_LAST_MESSAGES->pop_back();
482484
}
483485
// TODO try create global variable
484-
std::ofstream logFile(WSJCppLog::g_LOG_FILE, std::ios::app);
486+
std::ofstream logFile(WSJCppLog::g_WSJCPP_LOG_FILE, std::ios::app);
485487
if (!logFile) {
486488
std::cout << "Error Opening File" << std::endl;
487489
return;

src/wsjcpp_core.h

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -80,10 +80,12 @@ class WSJCppColorModifier {
8080

8181
class WSJCppLog {
8282
public:
83-
static std::string g_LOG_DIR;
84-
static std::string g_PREFIX_LOG_FILE;
85-
static std::string g_LOG_FILE;
86-
static long g_LOG_START_TIME;
83+
static std::string g_WSJCPP_LOG_DIR;
84+
static std::string g_WSJCPP_LOG_PREFIX_FILE;
85+
static std::string g_WSJCPP_LOG_FILE;
86+
static long g_WSJCPP_LOG_START_TIME;
87+
static std::mutex * g_WSJCPP_LOG_MUTEX;
88+
static std::deque<std::string> * g_WSJCPP_LOG_LAST_MESSAGES;
8789
static void doLogRotateUpdateFilename(bool bForce = false);
8890

8991
static void info(const std::string &sTag, const std::string &sMessage);

0 commit comments

Comments
 (0)