Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

date lookup fails with certain combinations of transitive dependencies #157

Open
ksunden opened this issue Jun 14, 2022 · 1 comment
Open

Comments

@ksunden
Copy link
Member

ksunden commented Jun 14, 2022

dateparser and regex have some version incompatibilities which cause the former to try to parse a regex with r"\d" in it and the latter to not recognize that as a valid escape class (for digits)

Not sure who is to blame, but it really makes a nice feature of ours not work... This is probably more of an upstream bug, not sure we Can do anything other than pin versions, which is not the best path going forward...

@ksunden
Copy link
Member Author

ksunden commented Aug 1, 2022

In doing this, we should probably drop maya as a dependency and rely only on dateparser.

The only feature we use from maya is maya.when which is a thin shim of dateparser.parse which simply raises an exception when the latter returns None.

Further, maya is basically unmaintained at this point, while dateparser is still maintained (though admittedly not as much as I'd like, it currently relies on pinning an old version of regex instead of updating to use the current version or using stdlib re (which they do use some extensions provided by regex, so can't blame them too hard))

I like the natural language parsing we have, I think it adds significantly to the usability of the attune store, but yeah, I wish things were a bit more stable on the parser end.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant