Skip to content

Commit 76ec439

Browse files
committed
fix : document-private-items ci
1 parent 64111f9 commit 76ec439

4 files changed

Lines changed: 18 additions & 18 deletions

File tree

provekit/prover/src/bigint_mod.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -622,7 +622,7 @@ pub fn ec_point_add(
622622
(x3, y3)
623623
}
624624

625-
/// EC scalar multiplication via double-and-add: returns [scalar]*P.
625+
/// EC scalar multiplication via double-and-add: returns \[scalar\]*P.
626626
pub fn ec_scalar_mul(
627627
px: &[u64; 4],
628628
py: &[u64; 4],

provekit/r1cs-compiler/src/msm/ec_points.rs

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -115,8 +115,8 @@ fn point_select_unchecked<F: FieldOps>(
115115

116116
/// Builds a point table for windowed scalar multiplication.
117117
///
118-
/// T[0] = P (dummy entry, used when window digit = 0)
119-
/// T[1] = P, T[2] = 2P, T[i] = T[i-1] + P for i >= 3.
118+
/// T\[0\] = P (dummy entry, used when window digit = 0)
119+
/// T\[1\] = P, T\[2\] = 2P, T\[i\] = T\[i-1\] + P for i >= 3.
120120
fn build_point_table<F: FieldOps>(
121121
ops: &mut F,
122122
px: F::Elem,
@@ -137,8 +137,8 @@ fn build_point_table<F: FieldOps>(
137137
table
138138
}
139139

140-
/// Selects T[d] from a point table using bit witnesses, where `d = Σ bits[i] *
141-
/// 2^i`.
140+
/// Selects T\[d\] from a point table using bit witnesses, where `d = Σ
141+
/// bits\[i\] * 2^i`.
142142
///
143143
/// Uses a binary tree of `point_select`s: processes bits from MSB to LSB,
144144
/// halving the candidate set at each level. Total: `(2^w - 1)` point selects
@@ -180,10 +180,10 @@ fn table_lookup<F: FieldOps>(
180180
///
181181
/// Structure per window (from MSB to LSB):
182182
/// 1. `w` shared doublings on accumulator
183-
/// 2. Table lookup in T_P[d1] for s1's window digit
184-
/// 3. point_add(acc, T_P[d1]) + is_zero(d1) + point_select
185-
/// 4. Table lookup in T_R[d2] for s2's window digit
186-
/// 5. point_add(acc, T_R[d2]) + is_zero(d2) + point_select
183+
/// 2. Table lookup in T_P\[d1\] for s1's window digit
184+
/// 3. point_add(acc, T_P\[d1\]) + is_zero(d1) + point_select
185+
/// 4. Table lookup in T_R\[d2\] for s2's window digit
186+
/// 5. point_add(acc, T_R\[d2\]) + is_zero(d2) + point_select
187187
///
188188
/// Returns the final accumulator (x, y).
189189
pub fn scalar_mul_glv<F: FieldOps>(

provekit/r1cs-compiler/src/msm/mod.rs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -680,10 +680,10 @@ fn decompose_point_to_limbs(
680680
}
681681
}
682682

683-
/// FakeGLV verification for a single point: verifies R = [s]P.
683+
/// FakeGLV verification for a single point: verifies R = \[s\]P.
684684
///
685685
/// Decomposes s via half-GCD into sub-scalars (s1, s2) and verifies
686-
/// [s1]P + [s2]R = O using interleaved windowed scalar mul with
686+
/// \[s1\]P + \[s2\]R = O using interleaved windowed scalar mul with
687687
/// half-width scalars.
688688
///
689689
/// Returns the mutable references back to the caller for continued use.
@@ -853,7 +853,7 @@ fn decompose_witness_to_limbs(
853853
limbs
854854
}
855855

856-
/// Recompose limbs back into a single witness: val = Σ limb[i] *
856+
/// Recompose limbs back into a single witness: val = Σ limb\[i\] *
857857
/// 2^(i*limb_bits)
858858
fn recompose_limbs(compiler: &mut NoirToR1CSCompiler, limbs: &[usize], limb_bits: u32) -> usize {
859859
let terms: Vec<SumTerm> = limbs

provekit/r1cs-compiler/src/msm/multi_limb_arith.rs

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -196,9 +196,9 @@ pub fn compute_is_zero(compiler: &mut NoirToR1CSCompiler, value: usize) -> usize
196196

197197
/// (a + b) mod p for multi-limb values.
198198
///
199-
/// Per limb i: v_i = a[i] + b[i] + 2^W - q*p[i] + carry_{i-1}
199+
/// Per limb i: v_i = a\[i\] + b\[i\] + 2^W - q*p\[i\] + carry_{i-1}
200200
/// carry_i = floor(v_i / 2^W)
201-
/// r[i] = v_i - carry_i * 2^W
201+
/// r\[i\] = v_i - carry_i * 2^W
202202
pub fn add_mod_p_multi(
203203
compiler: &mut NoirToR1CSCompiler,
204204
range_checks: &mut BTreeMap<u32, Vec<usize>>,
@@ -359,8 +359,8 @@ pub fn sub_mod_p_multi(
359359
/// (a * b) mod p for multi-limb values using schoolbook multiplication.
360360
///
361361
/// Verifies: a·b = p·q + r in base W = 2^limb_bits.
362-
/// Column k: Σ_{i+j=k} a[i]*b[j] + carry_{k-1} + OFFSET
363-
/// = Σ_{i+j=k} p[i]*q[j] + r[k] + carry_k * W
362+
/// Column k: Σ_{i+j=k} a\[i\]*b\[j\] + carry_{k-1} + OFFSET
363+
/// = Σ_{i+j=k} p\[i\]*q\[j\] + r\[k\] + carry_k * W
364364
pub fn mul_mod_p_multi(
365365
compiler: &mut NoirToR1CSCompiler,
366366
range_checks: &mut BTreeMap<u32, Vec<usize>>,
@@ -561,8 +561,8 @@ pub fn inv_mod_p_multi(
561561
}
562562

563563
/// Proves r < p by decomposing (p-1) - r into non-negative multi-limb values.
564-
/// Uses borrow propagation: d[i] = (p-1)[i] - r[i] + borrow_in - borrow_out *
565-
/// 2^W
564+
/// Uses borrow propagation: d\[i\] = (p-1)\[i\] - r\[i\] + borrow_in -
565+
/// borrow_out * 2^W
566566
fn less_than_p_check_multi(
567567
compiler: &mut NoirToR1CSCompiler,
568568
range_checks: &mut BTreeMap<u32, Vec<usize>>,

0 commit comments

Comments
 (0)