Skip to content

fix: handle identity attestation error #273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Takaros999 merged 3 commits into from
May 28, 2026
Merged

fix: handle identity attestation error #273

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
07be48c
fix: handle identity attestation error
Takaros999 May 28, 2026
da97a2f
fix
Takaros999 May 28, 2026
cf8389f
clippy
Takaros999 May 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions rust/core/src/bridge.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2631,6 +2631,14 @@ mod tests {
),
("invalid_timestamp", AppError::InvalidTimestamp),
("rp_signature_expired", AppError::RpSignatureExpired),
(
"identity_attributes_not_matched",
AppError::IdentityAttributesNotMatched,
),
(
"identity_attribute_mismatch",
AppError::IdentityAttributesNotMatched,
),
];

for (code, expected) in cases {
Expand Down
7 changes: 6 additions & 1 deletion rust/core/src/error.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,6 +160,8 @@ pub enum AppError {

/// Identity attributes did not match the required values
#[error("Identity attributes not matched")]
// An early android version using this error code instead of `identity_attributes_not_matched`
#[serde(alias = "identity_attribute_mismatch")]
IdentityAttributesNotMatched,

/// Generic error
Expand Down Expand Up @@ -196,7 +198,10 @@ impl AppError {
"timestamp_too_far_in_future" => Self::TimestampTooFarInFuture,
"invalid_timestamp" => Self::InvalidTimestamp,
"rp_signature_expired" => Self::RpSignatureExpired,
"identity_attributes_not_matched" => Self::IdentityAttributesNotMatched,
// An early android version using this error code instead of `identity_attributes_not_matched`
"identity_attributes_not_matched" | "identity_attribute_mismatch" => {
Self::IdentityAttributesNotMatched
}
_ => Self::GenericError,
}
}
Expand Down
Loading