Skip to content

Commit 05bc284

Browse files
committed
chore: migrate build-script approvals to pnpm-workspace allowBuilds
pnpm 11 no longer reads the package.json "pnpm" field, so onlyBuiltDependencies there was silently ignored. Move the approvals to allowBuilds in pnpm-workspace.yaml, carrying electron over so its binary-download postinstall isn't skipped on fresh installs, alongside the newly approved electron-winstaller. Also drop the overrides entry a stray `pnpm link` wrote (it rewrote the example's workspace:* resolution to link:..) and regenerate the lockfile, which picks up pnpm 11's libc metadata.
1 parent 8c3d00c commit 05bc284

3 files changed

Lines changed: 43 additions & 6 deletions

File tree

‎package.json‎

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -86,11 +86,5 @@
8686
},
8787
"engines": {
8888
"node": ">=20.0.0"
89-
},
90-
"pnpm": {
91-
"onlyBuiltDependencies": [
92-
"electron",
93-
"esbuild"
94-
]
9589
}
9690
}

‎pnpm-lock.yaml‎

Lines changed: 39 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎pnpm-workspace.yaml‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
11
packages:
22
- '.'
33
- example/
4+
allowBuilds:
5+
electron: true
6+
electron-winstaller: true
7+
esbuild: true

0 commit comments

Comments
 (0)