Add support for Ubuntu 22.04

Author: bd-clara

Diff for: README.md

@@ -19,9 +19,11 @@ Available variables are listed below, along with default values (see `defaults/m
     az_devops_accountname: null
     az_devops_accesstoken: null
     az_devops_project_name: null
-    az_devops_agent_version: 2.188.3
+    az_devops_agent_version: 2.218.1
     az_devops_agent_user: "az_devops_agent"
+    az_devops_agent_group: "az_devops_agent"
     az_devops_agent_uid: null
+    az_devops_agent_gid: null
     az_devops_agent_name: "{{ ansible_hostname }}"
     az_devops_server_url: "https://dev.azure.com/{{ az_devops_accountname }}"
     az_devops_agent_folder: "/home/{{ az_devops_agent_user }}/agent/"
@@ -69,6 +71,10 @@ Available variables are listed below, along with default values (see `defaults/m
 
   Default group of the user used to run and configure the service.
 
+- **az_devops_agent_gid**
+
+  GID of the user group used to run and configure the service.
+
 - **az_devops_agent_name**
 
   Name of the agent shown in Azure DevOps (defaults to the name of the host.).

Diff for: defaults/main.yml

@@ -1,4 +1,5 @@
-az_devops_agent_version: 2.188.3
+---
+az_devops_agent_version: 2.218.1
 az_devops_agent_user: "az_devops_agent"
 az_devops_agent_name: "{{ ansible_hostname }}"
 az_devops_server_url: "https://dev.azure.com/{{ az_devops_accountname }}/"
@@ -18,3 +19,5 @@ az_devops_proxy_url: null
 az_devops_proxy_username: null
 az_devops_proxy_password: null
 az_devops_agent_create_local_user: true
+az_devops_agent_legacy_dependencies: []
+...

Diff for: meta/main.yml

@@ -1,33 +1,38 @@
+---
 galaxy_info:
   role_name: azure_devops_agent
-  author: Yohan Belval
+  author: gsoft
   description: Azure DevOps Agent for Linux.
   company: GSoft
+  standalone: true
 
   license: "license (Apache-2.0)"
 
-  min_ansible_version: 2.4
+  min_ansible_version: "2.10"
 
   platforms:
     - name: Ubuntu
       versions:
         - xenial
         - bionic
         - focal
+        - jammy
     - name: EL
       versions:
-        - 7
+        - "7"
+        - "8"
     - name: Debian
       versions:
         - stretch
         - buster
+        - bullseye
     - name: Windows
       versions:
-        - 2016
-        - 2019
+        - "2016"
+        - "2019"
     - name: MacOSX
       versions:
-        - 10.15
+        - "10.15"
 
   galaxy_tags:
     - azure
@@ -37,3 +42,4 @@ galaxy_info:
     - deployment
     - ci
     - cd
+...

Diff for: tasks/Darwin.yml

@@ -1,10 +1,18 @@
+---
+- name: Add an agent group {{ az_devops_agent_group }}
+  ansible.builtin.group:
+    name: "{{ az_devops_agent_group }}"
+    gid: "{{ az_devops_agent_gid | default(omit) }}"
+    state: present
+  become: true
+
 - name: Add an agent user
   ansible.builtin.user:
     name: "{{ az_devops_agent_user }}"
     comment: "Azure DevOps Agent"
     shell: /bin/zsh
     group: "{{ az_devops_agent_group }}"
-    uid: "{{ az_devops_agent_uid|default(omit) }}"
+    uid: "{{ az_devops_agent_uid | default(omit) }}"
   become: true
 
 - name: Create directories
@@ -47,7 +55,7 @@
   register: svc_sh
   become: true
   changed_when: false
-  check_mode: no
+  check_mode: false
 
 - name: Check service status
   ansible.builtin.command: ./svc.sh status
@@ -57,7 +65,7 @@
     chdir: "{{ az_devops_agent_folder }}"
   register: svc_status
   changed_when: false
-  check_mode: no
+  check_mode: false
   when: svc_sh.stat.exists
 
 - name: Set agent config facts
@@ -89,17 +97,21 @@
 
 - name: Add deployment group tags
   ansible.builtin.set_fact:
-    deployment_agent_cmd_args: "{{ deployment_agent_cmd_args }} +
-      ['--addDeploymentGroupTags', '--deploymentGroupTags \\'{{ az_devops_deployment_group_tags }}\\'']"
+    deployment_agent_cmd_args: "{{ deployment_agent_cmd_args + ['--addDeploymentGroupTags', '--deploymentGroupTags', az_devops_deployment_group_tags] }}"
+  when:
+    - az_devops_deployment_group_tags is defined and az_devops_deployment_group_tags != None
+
+- name: Set proxy url
+  ansible.builtin.set_fact:
+    agent_cmd_args: "{{ agent_cmd_args + ['--proxyurl', az_devops_proxy_url] }}"
   when:
-    - az_devops_deployment_group_tags is defined
+    - az_devops_proxy_url is defined and az_devops_proxy_url != None
 
-- name: Set proxy
+- name: Set proxy username and password
   ansible.builtin.set_fact:
-    agent_cmd_args: "{{ agent_cmd_args }} + ['--proxyurl \\'{{ az_devops_proxy_url }}\\'',
-      '--proxyusername \\'{{ az_devops_proxy_username }}\\'', '--proxypassword \\'{{ az_devops_proxy_password }}\\'']"
+    agent_cmd_args: "{{ agent_cmd_args + ['--proxyusername', az_devops_proxy_username, '--proxypassword', az_devops_proxy_password] }}"
   when:
-    - az_devops_proxy_url is defined
+    - az_devops_proxy_url is defined and az_devops_proxy_url != None and az_devops_proxy_username != None and az_devops_proxy_password != None
 
 - name: Uninstall agent service
   ansible.builtin.command: ./svc.sh uninstall
@@ -125,9 +137,9 @@
 
 - name: Add '--replace' configuration argument
   ansible.builtin.set_fact:
-    build_agent_cmd_args: "{{ build_agent_cmd_args }} + ['--replace']"
-    deployment_agent_cmd_args: "{{ build_agent_cmd_args }} + ['--replace']"
-    resource_agent_cmd_args: "{{ resource_agent_cmd_args }} + ['--replace']"
+    build_agent_cmd_args: "{{ build_agent_cmd_args + ['--replace'] }}"
+    deployment_agent_cmd_args: "{{ build_agent_cmd_args + ['--replace'] }}"
+    resource_agent_cmd_args: "{{ resource_agent_cmd_args + ['--replace'] }}"
   when:
     - az_devops_agent_replace_existing
 
@@ -170,14 +182,18 @@
     section: null
     option: "{{ item.key }}"
     value: "{{ item.value }}"
-    no_extra_spaces: yes
+    no_extra_spaces: true
     owner: "{{ az_devops_agent_user }}"
     group: "{{ az_devops_agent_group }}"
+    mode: "0640"
   loop: "{{ az_devops_agent_user_capabilities | default({}) | dict2items }}"
   become: true
 
 - name: Install agent service
   ansible.builtin.command: ./svc.sh install {{ az_devops_agent_user }}
+  register: agent_install
+  failed_when: agent_install.rc != 0
+  changed_when: agent_install.rc == 0
   become: true
   become_user: "{{ az_devops_agent_user }}"
   args:
@@ -187,9 +203,13 @@
 
 - name: Start agent service
   ansible.builtin.command: ./svc.sh start
+  register: agent_start
+  failed_when: agent_start.rc != 0
+  changed_when: agent_start.rc == 0
   become: true
   become_user: "{{ az_devops_agent_user }}"
   args:
     chdir: "{{ az_devops_agent_folder }}"
   when:
     - (not service_is_running) or reconfigure_or_replace
+...

Diff for: tasks/Linux.yml

@@ -1,20 +1,21 @@
-- name: Add an agent user group
+---
+- name: Add an agent group {{ az_devops_agent_group }}
   ansible.builtin.group:
     name: "{{ az_devops_agent_group }}"
+    gid: "{{ az_devops_agent_gid | default(omit) }}"
     state: present
-    become: true
 
 - name: Add an agent user
   ansible.builtin.user:
     name: "{{ az_devops_agent_user }}"
     group: "{{ az_devops_agent_group }}"
-    uid: "{{ az_devops_agent_uid|default(omit) }}"
+    uid: "{{ az_devops_agent_uid | default(omit) }}"
     comment: "Azure DevOps Agent"
     shell: /bin/bash
   become: true
 
 - name: Create directories
-  ansible.bulitin.file:
+  ansible.builtin.file:
     state: directory
     path: "{{ item }}"
     owner: "{{ az_devops_agent_user }}"
@@ -27,8 +28,9 @@
 
 - name: Install Legacy dependencies
   ansible.builtin.apt:
-    name: "{{ az_devops_agent_legacy_dependencies }}"
+    deb: "{{ item }}"
     state: present
+  loop: "{{ az_devops_agent_legacy_dependencies }}"
   become: true
   when: ansible_os_family == "Debian"
 
@@ -51,7 +53,7 @@
   register: svc_sh
   become: true
   changed_when: false
-  check_mode: no
+  check_mode: false
 
 - name: Check service status
   ansible.builtin.command: ./svc.sh status
@@ -60,7 +62,7 @@
     chdir: "{{ az_devops_agent_folder }}"
   register: svc_status
   changed_when: false
-  check_mode: no
+  check_mode: false
   when: svc_sh.stat.exists
 
 - name: Check if bin/Agent.Listener exists
@@ -69,7 +71,7 @@
   register: bin_agent_listener
   become: true
   changed_when: false
-  check_mode: no
+  check_mode: false
 
 - name: Check agent version
   ansible.builtin.command: ./bin/Agent.Listener --version
@@ -78,7 +80,7 @@
     chdir: "{{ az_devops_agent_folder }}"
   register: agent_listener_version
   changed_when: false
-  check_mode: no
+  check_mode: false
   when: bin_agent_listener.stat.exists
 
 - name: Set agent config facts
@@ -114,22 +116,33 @@
 
 - name: Add deployment group tags
   ansible.builtin.set_fact:
-    deployment_agent_cmd_args: "{{ deployment_agent_cmd_args }} +
-      ['--addDeploymentGroupTags', '--deploymentGroupTags \\'{{ az_devops_deployment_group_tags }}\\'']"
+    deployment_agent_cmd_args: "{{ deployment_agent_cmd_args + ['--addDeploymentGroupTags', '--deploymentGroupTags', az_devops_deployment_group_tags] }}"
   when:
-    - az_devops_deployment_group_tags is defined
+    - az_devops_deployment_group_tags is defined and az_devops_deployment_group_tags != None
 
-- name: Set proxy
+- name: Set proxy url
   ansible.builtin.set_fact:
-    agent_cmd_args: "{{ agent_cmd_args }} + ['--proxyurl \\'{{ az_devops_proxy_url }}\\'', '--proxyusername \\'{{ az_devops_proxy_username }}\\'', '--proxypassword \\'{{ az_devops_proxy_password }}\\'']"
+    agent_cmd_args: "{{ agent_cmd_args + ['--proxyurl', az_devops_proxy_url] }}"
   when:
-    - az_devops_proxy_url is defined
+    - az_devops_proxy_url is defined and az_devops_proxy_url != None
 
-- name: Download and unarchive
+- name: Set proxy user and password
+  ansible.builtin.set_fact:
+    agent_cmd_args: "{{ agent_cmd_args + ['--proxyusername', az_devops_proxy_username, '--proxypassword', az_devops_proxy_password] }}"
+  when:
+    - az_devops_proxy_url is defined and az_devops_proxy_url != None and az_devops_proxy_username != None and az_devops_proxy_password != None
+
+- name: Download {{ az_devops_agent_package_url }}
+  ansible.builtin.get_url:
+    url: "{{ az_devops_agent_package_url }}"
+    dest: "/tmp/az_devops_agent_package.tar.gz"
+    mode: "0644"
+
+- name: Unarchive /tmp/az_devops_agent_package.tar.gz
   ansible.builtin.unarchive:
-    src: "{{ az_devops_agent_package_url }}"
+    src: "/tmp/az_devops_agent_package.tar.gz"
     dest: "{{ az_devops_agent_folder }}"
-    remote_src: yes
+    remote_src: true
     owner: "{{ az_devops_agent_user }}"
     group: "{{ az_devops_agent_group }}"
   become: true
@@ -159,9 +172,9 @@
 
 - name: Add '--replace' configuration argument
   ansible.builtin.set_fact:
-    build_agent_cmd_args: "{{ build_agent_cmd_args }} + ['--replace']"
-    deployment_agent_cmd_args: "{{ build_agent_cmd_args }} + ['--replace']"
-    resource_agent_cmd_args: "{{ resource_agent_cmd_args }} + ['--replace']"
+    build_agent_cmd_args: "{{ build_agent_cmd_args + ['--replace'] }}"
+    deployment_agent_cmd_args: "{{ build_agent_cmd_args + ['--replace'] }}"
+    resource_agent_cmd_args: "{{ resource_agent_cmd_args + ['--replace'] }}"
   when:
     - az_devops_agent_replace_existing
 
@@ -204,14 +217,18 @@
     section: null
     option: "{{ item.key }}"
     value: "{{ item.value }}"
-    no_extra_spaces: yes
+    no_extra_spaces: true
     owner: "{{ az_devops_agent_user }}"
     group: "{{ az_devops_agent_group }}"
+    mode: "0640"
   loop: "{{ az_devops_agent_user_capabilities | default({}) | dict2items }}"
   become: true
 
 - name: Install agent service
   ansible.builtin.command: ./svc.sh install {{ az_devops_agent_user }}
+  register: agent_install
+  failed_when: agent_install.rc != 0
+  changed_when: agent_install.rc == 0
   become: true
   args:
     chdir: "{{ az_devops_agent_folder }}"
@@ -220,8 +237,12 @@
 
 - name: Start agent service
   ansible.builtin.command: ./svc.sh start
+  register: agent_start
+  failed_when: agent_start.rc != 0
+  changed_when: agent_start.rc == 0
   become: true
   args:
     chdir: "{{ az_devops_agent_folder }}"
   when:
     - (not service_is_running) or reconfigure_or_replace
+...