Skip to content

Conversation

@timfdev
Copy link
Contributor

@timfdev timfdev commented Nov 25, 2025

closes #1145 , closes #1146

@codspeed-hq
Copy link

codspeed-hq bot commented Nov 25, 2025

CodSpeed Performance Report

Merging #1238 will not alter performance

Comparing feat/integration-tests-and-benchmarking (09bbf2c) with main (541ba43)

Summary

✅ 13 untouched

@sentry
Copy link

sentry bot commented Nov 25, 2025

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 80.22%. Comparing base (541ba43) to head (09bbf2c).

Files with missing lines Patch % Lines
orchestrator/cli/search/resize_embedding.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1238      +/-   ##
==========================================
+ Coverage   79.29%   80.22%   +0.92%     
==========================================
  Files         273      273              
  Lines       13347    13348       +1     
  Branches     1312     1312              
==========================================
+ Hits        10584    10708     +124     
+ Misses       2482     2343     -139     
- Partials      281      297      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@timfdev timfdev marked this pull request as ready for review November 26, 2025 14:46
Copy link
Collaborator

@acidjunk acidjunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with some small comments about pytest style

@pboers1988 pboers1988 merged commit 5882367 into main Nov 27, 2025
22 of 23 checks passed
@pboers1988 pboers1988 deleted the feat/integration-tests-and-benchmarking branch November 27, 2025 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature]: Facilitate E2E test with search scenario's [Feature]: Benchmark truncated vector size

5 participants