CRUD API calls for scheduler #1214
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1214 +/- ##
==========================================
- Coverage 79.29% 79.00% -0.30%
==========================================
Files 273 276 +3
Lines 13347 13471 +124
Branches 1312 1318 +6
==========================================
+ Hits 10584 10643 +59
- Misses 2482 2547 +65
Partials 281 281 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
CodSpeed Performance ReportMerging #1214 will not alter performanceComparing Summary
|
Mark90
requested changes
Nov 21, 2025
orchestrator/db/models.py
Outdated
Comment on lines
809
to
810
| # NOTE: Cannot use standard APScheduler job ID here because the table might not exist on migration | ||
| # Deleting on cascade happens on event based apscheduler job removal |
Contributor
There was a problem hiding this comment.
The apscheduler_jobs table is created in the migration before workflows_apscheduler_jobs is created, so isn't it always there?
orchestrator/schedules/service.py
Outdated
| if ( | ||
| not payload.trigger or | ||
| not payload.process_name or | ||
| not payload.name or |
Contributor
There was a problem hiding this comment.
Can't name default to the workflow name?
Contributor
Author
There was a problem hiding this comment.
what do you mean?
You need to provide these variables in order to create/update/delete, or am i missing something?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding CRUD api calls for scheduler, as mentioned here:
#1104