Add support for "RECONCILE" workflow target across schemas, tasks, and helpers

Author: Erik Stoel

orchestrator/devtools/populator.py

@@ -371,6 +371,22 @@ def start_modify_workflow(self, workflow_name: str, subscription_id: UUIDstr | U
         self.log.info("Started modify workflow")
         return self._start_workflow(workflow_name, subscription_id=subscription_id, **kwargs)
 
+    def start_reconcile_workflow(self, workflow_name: str, subscription_id: UUIDstr | UUID, **kwargs: Any) -> UUIDstr:
+        """Start a modify workflow for the provided name and subscription_id.
+
+        Args:
+            workflow_name: workflow name
+            subscription_id: uuid of the subscription you want to modify
+            kwargs: values to be used as form input
+
+        Returns: the process_id of the workflow process
+
+        """
+        subscription_id = str(subscription_id)
+        self.log = self.log.bind(subscription_id=subscription_id)
+        self.log.info("Started reconcile workflow")
+        return self._start_workflow(workflow_name, subscription_id=subscription_id, **kwargs)
+
     def start_verify_workflow(self, workflow_name: str, subscription_id: UUIDstr | UUID) -> UUIDstr:
         subscription_id = str(subscription_id)
         self.log = self.log.bind(subscription_id=subscription_id)

orchestrator/migrations/helpers.py

@@ -155,7 +155,7 @@ def create_workflow(conn: sa.engine.Connection, workflow: dict) -> None:
         conn: DB connection as available in migration main file.
         workflow: Dict with data for a new workflow.
             name: Name of the workflow.
-            target: Target of the workflow ("CREATE", "MODIFY", "TERMINATE", "SYSTEM")
+            target: Target of the workflow ("CREATE", "MODIFY", "RECONCILE", "TERMINATE", "SYSTEM")
             description: Description of the workflow.
             product_type: Product type to add the workflow to.
 

orchestrator/schemas/workflow.py

@@ -60,6 +60,7 @@ class SubscriptionWorkflowListsSchema(OrchestratorBaseModel):
     modify: list[WorkflowListItemSchema]
     terminate: list[WorkflowListItemSchema]
     system: list[WorkflowListItemSchema]
+    reconcile: list[WorkflowListItemSchema]
     validate_: list[WorkflowListItemSchema] = Field(default_factory=list, alias="validate")
 
 

orchestrator/workflows/tasks/validate_products.py

@@ -105,7 +105,7 @@ def check_that_products_have_create_modify_and_terminate_workflows() -> State:
     product_data = get_products(filters=[ProductTable.status == "active"])
 
     workflows_not_complete: list = []
-    targets = ["CREATE", "TERMINATE", "MODIFY", "VALIDATE"]
+    targets = ["CREATE", "TERMINATE", "MODIFY", "RECONCILE", "VALIDATE"]
     for product in product_data:
         workflows = {c.target for c in product.workflows if c.target in targets and c.name != "modify_note"}
         if len(workflows) < len(targets):