Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move login open event tracking from showLogin to view controller's viewWillAppear #567

Open
jaclync opened this issue Jan 25, 2021 · 0 comments

Comments

@jaclync
Copy link
Contributor

jaclync commented Jan 25, 2021

Idea from @diegoreymendez: wordpress-mobile/WordPress-iOS#15687 (comment)

Currently, .openedLogin event is tracked in showLogin when the source view controller is presenting login UI:

Now that we have a separate function loginUI for the host app to display login UI, the host app is responsible for tracking .openedLogin event but it could be easily missed. Let's move this event tracking to login view controller's viewWillAppear so that the host app doesn't have to manually track the event using both showLogin and loginUI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant