Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aztec: local changes detected after undo #8009

Closed
mzorz opened this issue Jul 10, 2018 · 5 comments
Closed

Aztec: local changes detected after undo #8009

mzorz opened this issue Jul 10, 2018 · 5 comments

Comments

@mzorz
Copy link
Contributor

mzorz commented Jul 10, 2018

Expected behavior

If content remains identical to what the Editor was fed with, it should not show the Local changes label when adding content then undoing.

Actual behavior

Opening an existing post, adding a character then tapping on undo still makes the app believe there were changes made to the content.

Steps to reproduce the behavior

  1. Open existing post (make sure it's not a post with local changes at this point)
  2. Type a character
  3. Press Undo
  4. Press back and observe "Local Changes" label on the post list
Tested on [Google Pixel], Android [8.1]
@hypest
Copy link
Contributor

hypest commented Jul 13, 2018

👋 @mzorz , I think the expected behavior is for the case when the post doesn't have local changes before entering the editor, right? If so, I can edit the description to include this condition.

@mzorz
Copy link
Contributor Author

mzorz commented Jul 13, 2018

That's correct @hypest, I just edited the "steps to reporduce" part tonclude this precondition

@rachelmcr
Copy link
Contributor

In my testing, the issue here is that the "undo" action wasn't saved.

When I follow those steps to reproduce the issue, and then open the post again, I can see the changes that I made to the post even though those changes were removed with the "undo" button previously. (This also happens if I type a character and backspace to remove it; the character I added is saved locally.)

@stale
Copy link

stale bot commented Oct 16, 2019

This issue has been marked as stale because:

  • It has been inactive for the past year.
  • It isn't in a project or a milestone.
  • It hasn’t been labeled [Pri] Blocker, [Pri] High, or good first issue.

Please comment with an update if you believe this issue is still valid or if it can be closed. This issue will also be reviewed for validity and priority (cc @designsimply).

@designsimply
Copy link
Contributor

Still valid. Moved to wordpress-mobile/AztecEditor-Android#896.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants