Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

self-hosted-runner: detect non-GH runners that don't use self-hosted #286

Open
woodruffw opened this issue Dec 12, 2024 · 0 comments
Open
Labels
enhancement New feature or request false-negative

Comments

@woodruffw
Copy link
Owner

The current audit assumes that self-hosted is a reliable sentinel for whether a job runs on a self-hosted runner or not, but that turns out to not be the case: self-hosted runners can seemingly use any labels, assuming the underlying runner controller/orchestrator (?) can handle them.

This can be seen in e.g. the RunsOn service, where they have routing keys like this for self-hosted runners:

    runs-on:
      - runs-on=${{ github.run_id }}
      - runner=2cpu-linux-arm64

We should figure out a way to handle these. In practice there's probably nothing fully general here; we'll just need to walk the runs-on labels and flag anything that isn't a well-known label (which is a static list provided by GH itself).

@woodruffw woodruffw added enhancement New feature or request false-negative labels Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request false-negative
Projects
None yet
Development

No branches or pull requests

1 participant