Skip to content

Conversation

@julek-wolfssl
Copy link
Member

Add validation to ensure the cipher suite in the ServerHello matches the one specified in the HelloRetryRequest.

Copy link
Contributor

@rizlik rizlik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you consider checking ssl->options.cipherSuite* against the value on the wire while parsing the ServerHello instead of storing in a new variable? This also moves the check inside DoTls13ServerHello that looks like a better place for the check

@julek-wolfssl
Copy link
Member Author

@rizlik The check is already inside of DoTls13ServerHello so I'm not sure what you mean. I used a new variable because I wanted to make the check explicit but if you think it is safe to assume ssl->options.cipherSuite* does not change value then I can change it to re-use that.

@julek-wolfssl
Copy link
Member Author

Retest this please FAIL scripts/openssl.test

@rizlik
Copy link
Contributor

rizlik commented Oct 28, 2025

@rizlik The check is already inside of DoTls13ServerHello so I'm not sure what you mean.

disregard this .

I used a new variable because I wanted to make the check explicit but if you think it is safe to assume ssl->options.cipherSuite* does not change value then I can change it to re-use that.

It's ok to add a new variable then,

rizlik
rizlik previously approved these changes Oct 28, 2025
- Add validation to ensure the cipher suite in the ServerHello matches the one specified in the HelloRetryRequest.
- test_TLSX_CA_NAMES_bad_extension: use the same ciphersuite in HRR and SH
@douzzer douzzer merged commit 7085421 into wolfSSL:master Oct 31, 2025
261 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: RFC 8446 violation : WolfSSL accept HelloRetryRequests with changing ciphers

4 participants