-
Notifications
You must be signed in to change notification settings - Fork 901
Validate cipher suite after HelloRetryRequest #9340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
08903de to
ef0c81b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you consider checking ssl->options.cipherSuite* against the value on the wire while parsing the ServerHello instead of storing in a new variable? This also moves the check inside DoTls13ServerHello that looks like a better place for the check
|
@rizlik The check is already inside of |
|
Retest this please FAIL scripts/openssl.test |
disregard this .
It's ok to add a new variable then, |
- Add validation to ensure the cipher suite in the ServerHello matches the one specified in the HelloRetryRequest. - test_TLSX_CA_NAMES_bad_extension: use the same ciphersuite in HRR and SH
e0c8e05 to
7b7f9a4
Compare
Add validation to ensure the cipher suite in the ServerHello matches the one specified in the HelloRetryRequest.