Simplify onFileChange callback

wojtekmaj · wojtekmaj · commit 057a928e7ab0 · 2024-05-14T11:06:38.000+02:00
diff --git a/sample/create-react-app-5/src/Sample.tsx b/sample/create-react-app-5/src/Sample.tsx
@@ -43,8 +43,10 @@ export default function Sample() {
   function onFileChange(event: React.ChangeEvent<HTMLInputElement>): void {
     const { files } = event.target;
 
-    if (files && files[0]) {
-      setFile(files[0] || null);
+    const nextFile = files?.[0];
+
+    if (nextFile) {
+      setFile(nextFile);
     }
   }
 
diff --git a/sample/next-app/app/Sample.tsx b/sample/next-app/app/Sample.tsx
@@ -45,8 +45,10 @@ export default function Sample() {
   function onFileChange(event: React.ChangeEvent<HTMLInputElement>): void {
     const { files } = event.target;
 
-    if (files && files[0]) {
-      setFile(files[0] || null);
+    const nextFile = files?.[0];
+
+    if (nextFile) {
+      setFile(nextFile);
     }
   }
 
diff --git a/sample/next-pages/pages/Sample.tsx b/sample/next-pages/pages/Sample.tsx
@@ -41,8 +41,10 @@ export default function Sample() {
   function onFileChange(event: React.ChangeEvent<HTMLInputElement>): void {
     const { files } = event.target;
 
-    if (files && files[0]) {
-      setFile(files[0] || null);
+    const nextFile = files?.[0];
+
+    if (nextFile) {
+      setFile(nextFile);
     }
   }
 
diff --git a/sample/parcel2/Sample.tsx b/sample/parcel2/Sample.tsx
@@ -45,8 +45,10 @@ export default function Sample() {
   function onFileChange(event: React.ChangeEvent<HTMLInputElement>): void {
     const { files } = event.target;
 
-    if (files && files[0]) {
-      setFile(files[0] || null);
+    const nextFile = files?.[0];
+
+    if (nextFile) {
+      setFile(nextFile);
     }
   }
 
diff --git a/sample/vite/Sample.tsx b/sample/vite/Sample.tsx
@@ -43,8 +43,10 @@ export default function Sample() {
   function onFileChange(event: React.ChangeEvent<HTMLInputElement>): void {
     const { files } = event.target;
 
-    if (files && files[0]) {
-      setFile(files[0] || null);
+    const nextFile = files?.[0];
+
+    if (nextFile) {
+      setFile(nextFile);
     }
   }
 
diff --git a/sample/webpack5/Sample.tsx b/sample/webpack5/Sample.tsx
@@ -43,8 +43,10 @@ export default function Sample() {
   function onFileChange(event: React.ChangeEvent<HTMLInputElement>): void {
     const { files } = event.target;
 
-    if (files && files[0]) {
-      setFile(files[0] || null);
+    const nextFile = files?.[0];
+
+    if (nextFile) {
+      setFile(nextFile);
     }
   }
 

Original file line number	Diff line number	Diff line change
`@@ -43,8 +43,10 @@ export default function Sample() {`
`43`	`43`	`function onFileChange(event: React.ChangeEvent<HTMLInputElement>): void {`
`44`	`44`	`const { files } = event.target;`
`45`	`45`
`46`		`- if (files && files[0]) {`
`47`		`- setFile(files[0] \|\| null);`
	`46`	`+ const nextFile = files?.[0];`
	`47`	`+`
	`48`	`+ if (nextFile) {`
	`49`	`+ setFile(nextFile);`
`48`	`50`	`}`
`49`	`51`	`}`
`50`	`52`
Original file line number	Diff line number	Diff line change
`@@ -45,8 +45,10 @@ export default function Sample() {`
`45`	`45`	`function onFileChange(event: React.ChangeEvent<HTMLInputElement>): void {`
`46`	`46`	`const { files } = event.target;`
`47`	`47`
`48`		`- if (files && files[0]) {`
`49`		`- setFile(files[0] \|\| null);`
	`48`	`+ const nextFile = files?.[0];`
	`49`	`+`
	`50`	`+ if (nextFile) {`
	`51`	`+ setFile(nextFile);`
`50`	`52`	`}`
`51`	`53`	`}`
`52`	`54`
Original file line number	Diff line number	Diff line change
`@@ -41,8 +41,10 @@ export default function Sample() {`
`41`	`41`	`function onFileChange(event: React.ChangeEvent<HTMLInputElement>): void {`
`42`	`42`	`const { files } = event.target;`
`43`	`43`
`44`		`- if (files && files[0]) {`
`45`		`- setFile(files[0] \|\| null);`
	`44`	`+ const nextFile = files?.[0];`
	`45`	`+`
	`46`	`+ if (nextFile) {`
	`47`	`+ setFile(nextFile);`
`46`	`48`	`}`
`47`	`49`	`}`
`48`	`50`