NE-1007: change naming of auto bgp sessions #73
Merged
+164
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loulecrivain
force-pushed
the
fix/change-naming-of-auto-bgp-sessions
branch
from
112f867 to
e7d9575
Compare
loulecrivain
changed the title
loulecrivain
force-pushed
the
fix/change-naming-of-auto-bgp-sessions
branch
from
e7d9575 to
073ebee
Compare
loulecrivain
force-pushed
the
fix/change-naming-of-auto-bgp-sessions
branch
from
073ebee to
aeaa3d5
Compare
+ also keep old naming as a fallback when no tobago lines are attached + old naming still available using deprecated_naming:cpe tag + test suite updated with all cases for new/old naming scheme switch
after changes to CosmoTobagoLine internal data structure on main branch, test data for this PR was outdated. thus tests were failing. this commit addresses the issue by adding missing service and tenant info.
loulecrivain
force-pushed
the
fix/change-naming-of-auto-bgp-sessions
branch
from
aeaa3d5 to
4cd498e
Compare
johannwagner
approved these changes
Dec 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
will be rebased once #72 is merged
relevant commit is 112f867