Attempt to invoke virtual method 'void.com.facebook.react.uimanager.UIManagerModule.onBatchComplete()' on a null object reference #3397

muzhaqi16 · 2024-11-20T03:08:18Z

Description

Attempt to invoke virtual method 'void.com.facebook.react.uimanager.UIManagerModule.onBatchComplete()' on a null object reference

Related to

Components
Demo
Docs
Typings

Steps to reproduce

Steps to reproduce the behavior:

Create a new project with react-native": "^0.76"
Setup react-native-ui-lib
Add a TextField from react-native-ui-lib
See error Attempt to invoke virtual method 'void.com.facebook.react.uimanager.UIManagerModule.onBatchComplete()' on a null object reference

Expected behavior

For the app not to crash

Actual behavior

App crashes

More Info

Code snippet

      <View flex paddingH-25 paddingT-120>
        <Text blue50 text20>
          Welcome
        </Text>
        <TextField text50 placeholder="username" grey10 />
        <TextField text50 placeholder="password" secureTextEntry grey10 />
        <View marginT-100 center>
          <Button text70 white background-orange30 label="Login" />
          <Button link text70 orange30 label="Sign Up" marginT-20 />
        </View>
      </View>

Screenshots/Video

Environment

System:
  OS: Windows 11 10.0.26100
  CPU: (20) x64 12th Gen Intel(R) Core(TM) i9-12900HK
  Memory: 14.56 GB / 31.69 GB
Binaries:
  Node:
    version: 20.18.0
    path: C:\Program Files\nodejs\node.EXE
  Yarn:
    version: 1.22.22
    path: C:\Program Files\nodejs\yarn.CMD
  npm:
    version: 10.8.2
    path: C:\Program Files\nodejs\npm.CMD
  Watchman:
    version: 20241103.093242.0
    path: C:\ProgramData\chocolatey\bin\watchman.EXE
SDKs:
  Android SDK:
    API Levels:
      - "34"
      - "35"
    Build Tools:
      - 34.0.0
      - 35.0.0
    System Images:
      - android-35 | Google Play Intel x86_64 Atom
    Android NDK: Not Found
  Windows SDK:
    AllowDevelopmentWithoutDevLicense: Enabled
IDEs:
  Android Studio: AI-242.23339.11.2421.12550806
  Visual Studio: Not Found
Languages:
  Java:
    version: 17.0.13
    path: /c/Program Files/Microsoft/jdk-17.0.13.11-hotspot/bin/javac
  Ruby: Not Found
npmPackages:
  "@react-native-community/cli":
    installed: 15.0.1
    wanted: 15.0.1
  react:
    installed: 18.3.1
    wanted: 18.3.1
  react-native:
    installed: 0.76.2
    wanted: 0.76.2
  react-native-windows: Not Found
npmGlobalPackages:
  "*react-native*": Not Found
Android:
  hermesEnabled: true
  newArchEnabled: true
iOS:
  hermesEnabled: Not found
  newArchEnabled: Not found

React Native version: "0.76.2"
React Native UI Lib version: "^7.34.2"
"react-native-gesture-handler": "^2.21.2",
"react-native-reanimated": "^3.16.1",

Affected platforms

Android
iOS
Web

The text was updated successfully, but these errors were encountered:

jameskennethrobinson · 2024-12-03T01:35:16Z

Commenting out the following line in RuntimeUtils.java fixes the issue:

ReactContextHolder.getContext().getNativeModule(UIManagerModule.class).onBatchComplete();

Not sure what the long term solution is.

package com.wix.reactnativeuilib.keyboardinput.utils;

import com.facebook.react.uimanager.UIManagerModule;
import com.wix.reactnativeuilib.keyboardinput.ReactContextHolder;

public class RuntimeUtils {

    // TODO Switch to GuardedRunnable when upgrading RN's minimal ver
    private static final Runnable sUIUpdateClosure = new Runnable() {
        @Override
        public void run() {
            ReactContextHolder.getContext().getNativeModule(UIManagerModule.class).onBatchComplete();
        }
    };

    public static void runOnUIThread(Runnable runnable) {
        if (ReactContextHolder.getContext() != null) {
            ReactContextHolder.getContext().runOnUiQueueThread(runnable);
        }
    }

    public static void dispatchUIUpdates(final Runnable userRunnable) {
        runOnUIThread(new Runnable() {
            @Override
            public void run() {
                userRunnable.run();
                if (ReactContextHolder.getContext() != null) {
                    ReactContextHolder.getContext().runOnNativeModulesQueueThread(sUIUpdateClosure);
                }
            }
        });
    }
}

adids1221 · 2024-12-17T13:51:44Z

Hi @muzhaqi16 does it reproduce on project with RN 0.73 ?

matice2 · 2024-12-18T13:53:44Z

still not fixed? 🙁

JoseAIG · 2024-12-20T16:04:54Z

Waiting for this fix

AhmedMaqbool · 2024-12-21T05:53:40Z

Having the same error can anybody recommend a fix till they resolve the issue

adids1221 · 2024-12-22T08:09:50Z

@matice2 @JoseAIG @AhmedMaqbool
Does the issue reproduce on RN 0.73?
Currently we are supporting RN 0.73, we will try to check this issue.

AhmedMaqbool · 2024-12-22T09:52:50Z

@matice2 @JoseAIG @AhmedMaqbool Does the issue reproduce on RN 0.73? Currently we are supporting RN 0.73, we will try to check this issue.

Okay this only works on 0.73 my project is using 0.76 any sort of timeline when you guys will start supporting 0.76

subhranshuchoudhury · 2024-12-27T10:34:59Z

I am getting the same error kindly fix it. i am only using the Carousel component

Astremy · 2025-01-02T09:12:04Z

Same problem

…t reference Fixes wix#3397

d1kssS · 2025-01-14T19:17:00Z

I have the same problem. I have this error when input field on focus, and when hide application, and come back i get this error

AnthonyCerdasAnalisis · 2025-01-16T01:26:24Z

Same problem here for TextField. "react": "^18.3.1",
"react-native": "0.76.6", "react-native-ui-lib": "^7.0.0",

sadewole · 2025-01-20T10:43:48Z

Same issue. Please, when will this problem be fixed??

sadewole · 2025-01-20T11:06:13Z

@matice2 @JoseAIG @AhmedMaqbool Does the issue reproduce on RN 0.73? Currently we are supporting RN 0.73, we will try to check this issue.

So when will this issue be fixed for latest react-native: 0.76.6 ??

vitoalmeida · 2025-01-22T13:53:18Z

I needed to update sUIUpdateClosure at this paths:
node_modules/react-native-ui-lib/lib/android/src/main/java/com/wix/reactnativeuilib/keyboardinput/utils/RuntimeUtils.java
and
/home/vito/GitHub/mobile-apps/apps/user-mobile/node_modules/uilib-native/android/src/main/java/com/wix/reactnativeuilib/keyboardinput/utils/RuntimeUtils.java

From this:

    private static final Runnable sUIUpdateClosure = new Runnable() {
        @Override
        public void run() {
            ReactContextHolder.getContext().getNativeModule(UIManagerModule.class).onBatchComplete();
        }
    };

To this:

    private static final Runnable sUIUpdateClosure = new Runnable() {
        @Override
        public void run() {
            try {
                UIManagerModule uiManager = ReactContextHolder.getContext()
                        .getNativeModule(UIManagerModule.class);
                if (uiManager != null) {
                    uiManager.onBatchComplete();
                } else {
                    // Log the error or handle it accordingly
                    System.err.println("UIManagerModule is null, cannot call onBatchComplete");
                }
            } catch (Exception e) {
                e.printStackTrace();
            }
        }
    };

And it works to me.

I need to add this to patch-package too

relez · 2025-01-30T15:42:58Z

Any update on this? I have installed the lastest version 7.36.0 and still the issue persists.

Thanks!

mihaibulic2 · 2025-02-15T23:05:43Z

As was already said (and is mentioned in the first paragraph of the repo's README) — this library only supports RN 0.73. They'll support 0.77 at some point (no timeline given)

Clarity aside, being over a year behind the official RN releases is a deal breaker for us, so we have to remove our dep on this lib

jameskennethrobinson · 2025-02-15T23:33:51Z

The fix I suggested earlier works great. No problem using with 0.77

…

On Sat, Feb 15, 2025 at 16:06 mihaibulic2 ***@***.***> wrote: *As was already said — this library only supports RN 0.73. They'll support 0.77 at some point (no timeline given)* Personally, being over a year behind the official RN releases is a deal breaker, so I'm removing my dep on RN UI lib. — Reply to this email directly, view it on GitHub <#3397 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AB53IRJTBUMYKPRA43M2YPL2P7B53AVCNFSM6AAAAABSDRUKGSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNRRGE2DAMRTHE> . You are receiving this because you were mentioned.Message ID: ***@***.***> [image: mihaibulic2]*mihaibulic2* left a comment (wix/react-native-ui-lib#3397) <#3397 (comment)> *As was already said — this library only supports RN 0.73. They'll support 0.77 at some point (no timeline given)* Personally, being over a year behind the official RN releases is a deal breaker, so I'm removing my dep on RN UI lib. — Reply to this email directly, view it on GitHub <#3397 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AB53IRJTBUMYKPRA43M2YPL2P7B53AVCNFSM6AAAAABSDRUKGSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNRRGE2DAMRTHE> . You are receiving this because you were mentioned.Message ID: ***@***.***>

deidine · 2025-02-17T09:28:27Z

`
diff --git a/lib/android/src/main/java/com/wix/reactnativeuilib/keyboardinput/utils/RuntimeUtils.java b/lib/android/src/main/java/com/wix/reactnativeuilib/keyboardinput/utils/RuntimeUtils.java
index 95c5e8ea473c83e2b95a47b42945befe13e69de2..cddcab08cc6c00f49612b7db56f446c1605f84aa 100644
--- a/lib/android/src/main/java/com/wix/reactnativeuilib/keyboardinput/utils/RuntimeUtils.java
+++ b/lib/android/src/main/java/com/wix/reactnativeuilib/keyboardinput/utils/RuntimeUtils.java
@@ -9,7 +9,10 @@ public class RuntimeUtils {
private static final Runnable sUIUpdateClosure = new Runnable() {
@OverRide
public void run() {

       ReactContextHolder.getContext().getNativeModule(UIManagerModule.class).onBatchComplete();

       var nativeModule = ReactContextHolder.getContext().getNativeModule(UIManagerModule.class);

```
       if (nativeModule != null) {
```

           nativeModule.onBatchComplete();

```
       }
   }
```
};

`

i didcthis patch and still facing the smae issues

iwalker7 · 2025-02-18T00:40:43Z

hey @deidine also patch uilib-native package. its dependency

deidine · 2025-02-18T09:12:05Z

@iwalker7 > hey @deidine also patch uilib-native package. its dependency
what you mean can you explain pls

iwalker7 · 2025-02-18T10:17:50Z

@iwalker7 > hey @deidine also patch uilib-native package. its dependency what you mean can you explain pls

check it out #3397 (comment)

WraithIT · 2025-02-25T15:28:10Z

I applied the fix and used patch-package, but it still gives me the same error
Rn: 0.77
expo: 0.52
react-native-ui-lib: ^7.37.2

@iwalker7 @vitoalmeida

vyestuary · 2025-02-28T02:33:17Z

I applied the fix and used patch-package, but it still gives me the same error Rn: 0.77 expo: 0.52 react-native-ui-lib: ^7.37.2

@iwalker7 @vitoalmeida

patch the uilib-native too.

TweetyBoop1990 · 2025-03-02T02:54:32Z

I applied the patch, works great but now my Dialogs on Android don't work correctly. Anyone else have this issue?

ferretwithaberet · 2025-03-02T22:04:54Z

I applied the patch, works great but now my Dialogs on Android don't work correctly. Anyone else have this issue?

What issue did you run into? I applied the patch to both react-native-ui-lib and uilib-native and it works perfectly fine, I tested with a RNUI Dialog.

olivier-nerot · 2025-03-23T23:16:34Z

For those who still have the bug after patching files, cleaning npm cache may help :

rm -rf node_modules
rm package-lock.json
npm cache clean --force
npm start -- --reset-cache

empro-narendervaddepelly · 2025-03-24T18:00:43Z

Still same issue

dhruvpaobs · 2025-04-05T05:01:53Z

I tried the patch, but it's not working with 'react-native': '0.78.1' and 'react-native-ui-lib': '^7.39.1'.

t-yag · 2025-04-12T09:00:57Z

The patch worked well in my environment.

expo: 52.0.42
react-native: 0.76.9
react-native-ui-lib: 7.39.0

As already mentioned, the patch needs to be applied not only to react-native-ui-lib but also to uilib-native.
Just to be safe, I applied patches to both. The directory structure looks like this:

📁patches
┣ 📄react-native-ui-lib+7.39.0.patch
┗ 📄uilib-native+4.5.1.patch

muzhaqi16 added the bug a bug in one of the components label Nov 20, 2024

github-actions bot added the waiting-for-response label Dec 17, 2024

Yimura added a commit to Yimura/react-native-ui-lib that referenced this issue Jan 9, 2025

fix: crash on invoke virtual method onBatchComplete on a null objec…

369c88f

…t reference Fixes wix#3397

adids1221 mentioned this issue Jan 23, 2025

replace direct uilib-native imports with optionalDeps, react-native new architecture issues #3492

Draft

2 tasks

khanhdevvn mentioned this issue Mar 13, 2025

Attempt to invoke virtual method 'void com.facebook.react.uimanager.UlManagerModule.onBatchComplete()' on a null object reference #3594

Open

7 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Attempt to invoke virtual method 'void.com.facebook.react.uimanager.UIManagerModule.onBatchComplete()' on a null object reference #3397

Attempt to invoke virtual method 'void.com.facebook.react.uimanager.UIManagerModule.onBatchComplete()' on a null object reference #3397

muzhaqi16 commented Nov 20, 2024

jameskennethrobinson commented Dec 3, 2024

adids1221 commented Dec 17, 2024

matice2 commented Dec 18, 2024

JoseAIG commented Dec 20, 2024

AhmedMaqbool commented Dec 21, 2024

adids1221 commented Dec 22, 2024

AhmedMaqbool commented Dec 22, 2024

subhranshuchoudhury commented Dec 27, 2024

Astremy commented Jan 2, 2025

d1kssS commented Jan 14, 2025

AnthonyCerdasAnalisis commented Jan 16, 2025

sadewole commented Jan 20, 2025

sadewole commented Jan 20, 2025

vitoalmeida commented Jan 22, 2025 •

edited

Loading

relez commented Jan 30, 2025

mihaibulic2 commented Feb 15, 2025 •

edited

Loading

jameskennethrobinson commented Feb 15, 2025 via email

deidine commented Feb 17, 2025

iwalker7 commented Feb 18, 2025

deidine commented Feb 18, 2025 •

edited

Loading

iwalker7 commented Feb 18, 2025

WraithIT commented Feb 25, 2025 •

edited

Loading

vyestuary commented Feb 28, 2025

TweetyBoop1990 commented Mar 2, 2025

ferretwithaberet commented Mar 2, 2025

olivier-nerot commented Mar 23, 2025

empro-narendervaddepelly commented Mar 24, 2025

dhruvpaobs commented Apr 5, 2025

t-yag commented Apr 12, 2025

Attempt to invoke virtual method 'void.com.facebook.react.uimanager.UIManagerModule.onBatchComplete()' on a null object reference #3397

Attempt to invoke virtual method 'void.com.facebook.react.uimanager.UIManagerModule.onBatchComplete()' on a null object reference #3397

Comments

muzhaqi16 commented Nov 20, 2024

Description

Related to

Steps to reproduce

Expected behavior

Actual behavior

More Info

Code snippet

Screenshots/Video

Environment

Affected platforms

jameskennethrobinson commented Dec 3, 2024

adids1221 commented Dec 17, 2024

matice2 commented Dec 18, 2024

JoseAIG commented Dec 20, 2024

AhmedMaqbool commented Dec 21, 2024

adids1221 commented Dec 22, 2024

AhmedMaqbool commented Dec 22, 2024

subhranshuchoudhury commented Dec 27, 2024

Astremy commented Jan 2, 2025

d1kssS commented Jan 14, 2025

AnthonyCerdasAnalisis commented Jan 16, 2025

sadewole commented Jan 20, 2025

sadewole commented Jan 20, 2025

vitoalmeida commented Jan 22, 2025 • edited Loading

relez commented Jan 30, 2025

mihaibulic2 commented Feb 15, 2025 • edited Loading

jameskennethrobinson commented Feb 15, 2025 via email

deidine commented Feb 17, 2025

iwalker7 commented Feb 18, 2025

deidine commented Feb 18, 2025 • edited Loading

iwalker7 commented Feb 18, 2025

WraithIT commented Feb 25, 2025 • edited Loading

vyestuary commented Feb 28, 2025

TweetyBoop1990 commented Mar 2, 2025

ferretwithaberet commented Mar 2, 2025

olivier-nerot commented Mar 23, 2025

empro-narendervaddepelly commented Mar 24, 2025

dhruvpaobs commented Apr 5, 2025

t-yag commented Apr 12, 2025

vitoalmeida commented Jan 22, 2025 •

edited

Loading

mihaibulic2 commented Feb 15, 2025 •

edited

Loading

deidine commented Feb 18, 2025 •

edited

Loading

WraithIT commented Feb 25, 2025 •

edited

Loading