Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add wait to code sample #10544

Merged
merged 2 commits into from
Dec 27, 2024
Merged

fix: add wait to code sample #10544

merged 2 commits into from
Dec 27, 2024

Conversation

justinnoel
Copy link
Contributor

Description

When calling an action from a server endpoint, an await is required or data and error will be undefined.

@justinnoel
fix: add wait to code sample
24a13d8 
When calling an action from a server endpoint, an `await` is required or `data` and `error` will be `undefined`.
@netlify Netlify
Copy link

netlify bot commented Dec 27, 2024 •
edited
Loading

✅ Deploy Preview for astro-docs-2 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 378d0a1
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/676eb6d62be41c000899d19c
😎 Deploy Preview https://deploy-preview-10544--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@astrobot-houston
Copy link
Contributor

astrobot-houston commented Dec 27, 2024 •
edited
Loading

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
en/guides/actions.mdx Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@astrobot-houston
Copy link
Contributor

Hello! Thank you for opening your first PR to Astro’s Docs! 🎉

Here’s what will happen next:

  1. Our GitHub bots will run to check your changes.
    If they spot any broken links you will see some error messages on this PR.
    Don’t hesitate to ask any questions if you’re not sure what these mean!

  2. In a few minutes, you’ll be able to see a preview of your changes on Netlify 🥳.

  3. One or more of our maintainers will take a look and may ask you to make changes.
    We try to be responsive, but don’t worry if this takes a few days.

sarah11918
sarah11918 approved these changes Dec 27, 2024
View reviewed changes
Copy link
Member

@sarah11918 sarah11918 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for catching this @justinnoel and taking the time to add the fix. And welcome to Team Docs 🥳 (But, how is this your first contribution?? 😄 )

@sarah11918 sarah11918 added code snippet update Updates a code sample: typo, outdated code etc. Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! labels Dec 27, 2024
@sarah11918 sarah11918 merged commit 8cd5ca7 into withastro:main Dec 27, 2024
5 of 6 checks passed
@jsparkdev jsparkdev mentioned this pull request Dec 28, 2024
Merged
@justinnoel
Copy link
Contributor Author

But, how is this your first contribution??

I only built a few simple things with Astro all those years ago. Then, I spent a lot of time with Hono. Now, I'm back to dabbling with Astro. It's amazing what y'all have done with it!!!

@justinnoel justinnoel deleted the patch-1 branch December 28, 2024 13:43
thomasbnt added a commit to thomasbnt/docs that referenced this pull request Dec 29, 2024
@thomasbnt
i18n(fr): Update guides/actions.mdx from withastro#10544
5225d1f
@thomasbnt thomasbnt mentioned this pull request Dec 29, 2024
Merged
thomasbnt added a commit that referenced this pull request Dec 29, 2024
@thomasbnt
i18n(fr): Update guides/actions.mdx from #10544 (#10550)
a5ff8f5 
* i18n(fr): Update `guides/actions.mdx` from #10544

* i18n(fr): Update `guides/actions.mdx` from #10501

* "ctx" to "context" from #10304

Co-authored-by : Armand Philippot <[email protected]>
@Nin3lee Nin3lee mentioned this pull request Dec 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarah11918 sarah11918 sarah11918 approved these changes

Assignees
No one assigned
Labels
code snippet update Updates a code sample: typo, outdated code etc. Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@justinnoel @astrobot-houston @sarah11918