Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make snapshot releases build the wasm #991

Merged
merged 3 commits into from
Mar 29, 2024
Merged

Make snapshot releases build the wasm #991

merged 3 commits into from
Mar 29, 2024

Conversation

matthewp
Copy link
Contributor

Changes

  • Snapshot releases weren't building wasm. They should

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Mar 29, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: e5a2b0b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

MoustaphaDev
MoustaphaDev approved these changes Mar 29, 2024
View reviewed changes
Copy link
Member

@MoustaphaDev MoustaphaDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah that makes sense, let's hope that fixes it 🤞

@matthewp matthewp merged commit f657186 into main Mar 29, 2024
5 checks passed
@matthewp matthewp deleted the fix-snapshots branch March 29, 2024 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ematipico ematipico ematipico left review comments

@Fryuni Fryuni Fryuni left review comments

@MoustaphaDev MoustaphaDev MoustaphaDev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@matthewp @ematipico @Fryuni @MoustaphaDev