Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Fix expressions within td exitLiteralIM tracking (#885)" #889

Merged
merged 3 commits into from
Nov 14, 2023
Merged

Revert "Fix expressions within td exitLiteralIM tracking (#885)" #889

merged 3 commits into from
Nov 14, 2023

Conversation

natemoo-re
Copy link
Member

@natemoo-re natemoo-re commented Nov 14, 2023 •
edited
Loading

Changes

  • This reverts commit e241f2d.
  • Don't want to break people, going to release this quickly. Can circle back to actually fix the table issue.

Testing

The following case regressed, throwing a parsing error for the user. Notably, even with the regression, this case is still broken, albeit not fatally. Tables are fun! 😭

---
const content = "lol";
---

<html>
  <body>
    <table>
      <tr>
        <td>{content}</td>
      </tr>
      {
        (
          <tr>
            <td>1</td>
          </tr>
        )
      }
    </table>
     1
  </body>
</html>

Docs

N/A

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 14, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: 4d24210

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@astrojs/compiler Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@natemoo-re
Copy link
Member Author

YOLO'ing this since everyone else is offline but we don't want a regression out in the wild.

@natemoo-re natemoo-re merged commit 2bdb4bb into main Nov 14, 2023
@natemoo-re natemoo-re deleted the fix/revert-table branch November 14, 2023 22:52
@bluwy bluwy mentioned this pull request Nov 15, 2023
Closed
1 task
@bluwy bluwy mentioned this pull request Nov 29, 2023
Closed
@MoustaphaDev MoustaphaDev mentioned this pull request Dec 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@natemoo-re