Fix an issue with missing basePath being treated as an absolute path

Author: teppokoivula

CHANGELOG.md

@@ -11,6 +11,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ### Fixed
 - Fix an issue where a typo in ModuleInstaller prevented it from working properly.
+- Fix an issue with missing basePath being treated as an absolute path.
 
 ## [0.0.1] - 2019-06-03
 

src/ComposerInstaller/BaseInstaller.php

@@ -54,6 +54,12 @@ protected function getBasePath($defaultBasePath) {
         $type = strtolower(preg_replace('/(?<!^)[A-Z]/', '-$0', substr($class, 0, strrpos($class, 'Installer'))));
         $basePath = $extra['pw-' . $type . '-path'] ?? $defaultBasePath;
 
+        // if base path is set, make sure that it has a trailing slash
+        $basePath = trim($basePath, '/');
+        if (strlen($basePath)) {
+            $basePath .= '/';
+        }
+
         return $basePath;
     }
 
@@ -89,7 +95,6 @@ protected function getName(PackageInterface $package) {
     protected function getFullPath(PackageInterface $package, $defaultBasePath) {
         $basePath = $this->getBasePath($defaultBasePath);
         $name = $this->getName($package);
-        $path = trim($basePath, '/') . '/' . $name;
-        return $path;
+        return $basePath . $name;
     }
 }