Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

required option for non-primitive types in protobuf #58

Open
kostysh opened this issue Jun 9, 2022 · 0 comments
Open

required option for non-primitive types in protobuf #58

kostysh opened this issue Jun 9, 2022 · 0 comments
Labels
D-average Difficulty: average P-low Priority: low T-feature Type: feature
Milestone

Comments

@kostysh
Copy link
Contributor

kostysh commented Jun 9, 2022

The context:

  • All non-primitive types in protobuf are optional. So if it is a field that refers to another type, it's optional.
  • It's established in protobuf that compilation of a message field type is not defined as required or optional and is up to the compiler to determine how it is handled. Since protobuf 3 all fields that are primitives may be marked optional or required, but required syntax is now prohibited in proto3 as all primitives are assumed to be required unless marked optional.
  • this way non-primitive type such as Date cannot be marked as mandatory

The task:

  • investigate and figure out how to implement protobuf functionality that will allow us to mark non-primitive types as required
  • all required types including non-primitive types must be properly reflected in the autogenerated typescript code
@kostysh kostysh added D-average Difficulty: average P-low Priority: low T-feature Type: feature labels Jun 9, 2022
@mfw78 mfw78 added this to the TBD milestone Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
D-average Difficulty: average P-low Priority: low T-feature Type: feature
Projects
None yet
Development

No branches or pull requests

2 participants