Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: index garbage collector #31

Open
Galeaf11 opened this issue May 30, 2022 · 2 comments
Open

perf: index garbage collector #31

Galeaf11 opened this issue May 30, 2022 · 2 comments
Labels
D-average Difficulty: average P-low Priority: low T-perf Type: performance
Milestone

Comments

@Galeaf11
Copy link
Contributor

Galeaf11 commented May 30, 2022

Problem

The proposed solution for managing the leveldb creates a few indices that are used to store mappings. Over time, these indices will grow and potentially reduce the performance of lpms-server.

Solution

Establish a garbage collection routine whereby indices can automatically be trimmed from the database when not required. Care must be given not to delete information that would be required for audit purposes.

@mfw78 mfw78 added D-average Difficulty: average P-low Priority: low T-perf Type: performance labels May 30, 2022
@mfw78
Copy link
Contributor

mfw78 commented May 30, 2022

@lucarioams Can you please provide some input to this (not a high priority) as to how long lookup data / booking data should be retained, or do we just make this another configuration option, with a sane default value?

@xdaluca
Copy link
Contributor

xdaluca commented May 30, 2022

I think we should have a sane default here, e.g. 90-days. After that it gets deleted, they can chose to export it first and store it if they want.

@mfw78 mfw78 transferred this issue from windingtree/win-stays Jun 7, 2022
@mfw78 mfw78 added this to the TBD milestone Jun 7, 2022
@mfw78 mfw78 changed the title Index garbage collector perf: index garbage collector Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
D-average Difficulty: average P-low Priority: low T-perf Type: performance
Projects
None yet
Development

No branches or pull requests

3 participants