Skip to content

Commit 9a2fa44

Browse files
committed
pump to 3.3.1
1 parent 6829dee commit 9a2fa44

File tree

347 files changed

+55486
-26334
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

347 files changed

+55486
-26334
lines changed

.editorconfig

+4-4
Original file line numberDiff line numberDiff line change
@@ -3,12 +3,12 @@
33
root = true
44

55
[*]
6-
indent_style = space
7-
indent_size = 2
8-
end_of_line = lf
96
charset = utf-8
10-
trim_trailing_whitespace = true
7+
end_of_line = lf
8+
indent_size = 2
9+
indent_style = space
1110
insert_final_newline = true
11+
trim_trailing_whitespace = true
1212

1313
[*.py]
1414
indent_size = 4

.gitattributes

+1
Original file line numberDiff line numberDiff line change
@@ -5,4 +5,5 @@
55
*.json text eol=lf
66
*.less text eol=lf
77
*.md text eol=lf
8+
*.svg text eol=lf
89
*.yml text eol=lf

.gitignore

+9-9
Original file line numberDiff line numberDiff line change
@@ -6,37 +6,37 @@ _site
66
# Numerous always-ignore extensions
77
*.diff
88
*.err
9-
*.orig
109
*.log
10+
*.orig
1111
*.rej
1212
*.swo
1313
*.swp
14-
*.zip
1514
*.vi
15+
*.zip
1616
*~
1717

1818
# OS or Editor folders
19-
.DS_Store
2019
._*
21-
Thumbs.db
2220
.cache
21+
.DS_Store
22+
.idea
2323
.project
2424
.settings
2525
.tmproj
2626
*.esproj
27-
nbproject
2827
*.sublime-project
2928
*.sublime-workspace
30-
.idea
29+
nbproject
30+
Thumbs.db
3131

3232
# Komodo
33-
*.komodoproject
3433
.komodotools
34+
*.komodoproject
3535

3636
# grunt-html-validation
37-
validation-status.json
3837
validation-report.json
38+
validation-status.json
3939

4040
# Folders to ignore
41-
node_modules
4241
bower_components
42+
node_modules

.travis.yml

+26-9
Original file line numberDiff line numberDiff line change
@@ -1,28 +1,45 @@
11
language: node_js
2+
git:
3+
depth: 10
24
node_js:
35
- "0.10"
46
before_install:
5-
- time sudo pip install --use-mirrors -r test-infra/requirements.txt
7+
- travis_retry sudo pip install -r test-infra/requirements.txt
68
- rvm use 1.9.3 --fuzzy
7-
- if [ "$TWBS_TEST" = validate-html ]; then echo "ruby=$(basename $(rvm gemdir)) jekyll=$JEKYLL_VERSION" > pseudo_Gemfile.lock; fi
9+
- export GEMDIR=$(rvm gemdir)
10+
- if [ "$TWBS_TEST" = validate-html ]; then echo "ruby=$(basename $GEMDIR) jekyll=$JEKYLL_VERSION rouge=$ROUGE_VERSION" > pseudo_Gemfile.lock; fi
11+
- "export TRAVIS_COMMIT_MSG=\"$(git log --format=%B --no-merges -n 1)\""
12+
- echo "$TRAVIS_COMMIT_MSG" | grep '\[skip validator\]'; export TWBS_DO_VALIDATOR=$?; true
13+
- echo "$TRAVIS_COMMIT_MSG" | grep '\[skip sauce\]'; export TWBS_DO_SAUCE=$?; true
14+
- if [ "$TRAVIS_REPO_SLUG" = twbs-savage/bootstrap ]; then export TWBS_DO_VALIDATOR=0; fi
815
install:
9-
- time npm install -g grunt-cli
10-
- time ./test-infra/s3_cache.py download 'npm packages' test-infra/npm-shrinkwrap.canonical.json ./node_modules || time ./test-infra/uncached-npm-install.sh
11-
- if [ "$TWBS_TEST" = validate-html ]; then time ./test-infra/s3_cache.py download rubygems pseudo_Gemfile.lock $(rvm gemdir) || gem install -N jekyll -v $JEKYLL_VERSION; fi
16+
- npm install -g grunt-cli
17+
- ./test-infra/s3_cache.py download npm-modules
18+
- if [ "$TWBS_TEST" = validate-html ] && [ $TWBS_DO_VALIDATOR -ne 0 ]; then ./test-infra/s3_cache.py download rubygems; fi
1219
after_script:
13-
- if [ "$TWBS_TEST" = core ]; then time ./test-infra/s3_cache.py upload 'npm packages' test-infra/npm-shrinkwrap.canonical.json ./node_modules; fi
14-
- if [ "$TWBS_TEST" = validate-html ]; then time ./test-infra/s3_cache.py upload rubygems pseudo_Gemfile.lock $(rvm gemdir); fi
20+
- if [ "$TRAVIS_REPO_SLUG" != twbs-savage/bootstrap ] && [ "$TWBS_TEST" = core ]; then ./test-infra/s3_cache.py upload npm-modules; fi
21+
- if [ "$TRAVIS_REPO_SLUG" != twbs-savage/bootstrap ] && [ "$TWBS_TEST" = validate-html ] && [ $TWBS_DO_VALIDATOR -ne 0 ]; then ./test-infra/s3_cache.py upload rubygems; fi
1522
env:
1623
global:
17-
- JEKYLL_VERSION: 1.4.1
18-
- SAUCE_USERNAME: bootstrap
24+
- JEKYLL_VERSION="2.5.1"
25+
- ROUGE_VERSION="1.7.2"
26+
- SAUCE_USERNAME="bootstrap"
1927
- secure: "pJkBwnuae9dKU5tEcCqccfS1QQw7/meEcfz63fM7ba7QJNjoA6BaXj08L5Z3Vb5vBmVPwBawxo5Hp0jC0r/Z/O0hGnAmz/Cz09L+cy7dSAZ9x4hvZePSja/UAusaB5ogMoO8l2b773MzgQeSmrLbExr9BWLeqEfjC2hFgdgHLaQ="
2028
- secure: "gqjqISbxBJK6byFbsmr1AyP1qoWH+rap06A2gI7v72+Tn2PU2nYkIMUkCvhZw6K889jv+LhQ/ybcBxDOXHpNCExCnSgB4dcnmYp+9oeNZb37jSP0rQ+Ib4OTLjzc3/FawE/fUq5kukZTC7porzc/k0qJNLAZRx3YLALmK1GIdUY="
2129
- secure: "Gghh/e3Gsbj1+4RR9Lh2aR/xJl35HWiHqlPIeSUqE9D7uDCVTAwNce/dGL3Ew7uJPfJ6Pgr70wD3zgu3stw0Zmzayax0hiDtGwcQCxVIER08wqGANK9C2Q7PYJkNTNtiTo6ehKWbdV4Z+/U+TEYyQfpQTDbAFYk/vVpsdjp0Lmc="
2230
- secure: "RTbRdx4G/2OTLfrZtP1VbRljxEmd6A1F3GqXboeQTldsnAlwpsES65es5CE3ub/rmixLApOY9ot7OPmNixFgC2Y8xOsV7lNCC62QVpmqQEDyGFFQKb3yO6/dmwQxdsCqGfzf9Np6Wh5V22QFvr50ZLKLd7Uhd9oXMDIk/z1MJ3o="
31+
- secure: "RKWpS+P20b4tG9tawzCMJSmQftoonmC7tJzyGYiHuEM1TcpHALLBcnzKlr/+DiPTfzDJWY4kS8pxfhK4uXOe8OHnhpMNub7LEWtFPePlZIervOJcsOydaQocTKqVVWD6OUubMeQmQ+tZmvmpjoJ1uPPEbFs9ciF7+dv3U5tLUZ0="
32+
- secure: "XswSKBY0HJ/aO9VOBeWlvGpqSFF/DsJmNKz7o5RkJMJX340qe44J929uUNwwOwlv9YrgptzC2W6l8bpmZQV+p6IYs99SoSA8CCaUfIJaqeU9x/UiT5vIHgqaNax+vFJwvzHLpF5v/ggFqFEKCd54gCDasePLTztHeC4oL104iaQ="
33+
- secure: "Dv1HX5dzyTh8gA2YsLI+yWEgh9lnGKPpRDDEYYvm42fjBFziUYfcpvA9g8GXQuU9srY3mhfsZkCDHN0x5n1gliOai5TSjmd5Hh+9UyhvNWE+D8HoUpcFXWoQXvy/if2r25m+ZWi3cqgXkkBOcal3W1ePMtU4ln18NcWyIZ0tEFo="
34+
- secure: "PabpUdG2dE40hHUkMCdxk1e9Ak3BOo0h7Y5/uekosLKOz5N60Xmn/ooyrSkvicLthXO4cfONFhO3/xSVRKQOxlUw4on5i0VuNK+QSqxJk0IDaRSZnTCcC8J7083K0YL+FvMdGQwcYwMY9LiwS8aS014IRkSQjsa+mjo3owP+dOU="
35+
- secure: "G4/f4PVyVi9o6UbZMqw9YFmDu7cHqe9iymiXYd1RcnPXwhWAePX12m0PWMhUj5itJ180PTEddVip8PNOgBdqyrDxEPKkcgAW2EElVAPIKJXVfvDW64UjQ0H7NS7XvF7iLQUJp/XfmR7NJ7tT393AQdh8SGmuQpJhgYbwIWbES/k="
2336
matrix:
2437
- TWBS_TEST=core
2538
- TWBS_TEST=validate-html
2639
- TWBS_TEST=sauce-js-unit
2740
matrix:
2841
fast_finish: true
42+
notifications:
43+
slack: heybb:iz4wwosL0N0EdaX1gvgkU0NH
44+
webhooks:
45+
- http://savage.twbsapps.com/savage/travis

CONTRIBUTING.md

+64-15
Original file line numberDiff line numberDiff line change
@@ -29,13 +29,36 @@ restrictions:
2929
their respective repositories).
3030

3131

32+
## Issues and labels
33+
34+
Our bug tracker utilizes several labels to help organize and identify issues. Here's what they represent and how we use them:
35+
36+
- `browser bug` - Issues that are reported to us, but actually are the result of a browser-specific bug. These are diagnosed with reduced test cases and result in a issue opened on that browser's own bug tracker.
37+
- `confirmed` - Issues that have been confirmed with a reduced test case and identify a bug in Bootstrap.
38+
- `css` - Issues stemming from our compiled CSS or source Less files.
39+
- `customizer` - Issues with our web-based Customizer.
40+
- `docs` - Issues for improving or updating our documentation.
41+
- `examples` - Issues involving the example templates included in our docs.
42+
- `feature` - Issues asking for a new feature to be added, or an existing one to be extended or modified. New features require a minor version bump (e.g., `v3.0.0` to `v3.1.0`).
43+
- `grunt` - Issues with our included JavaScript-based Gruntfile, which is used to run all our tests, concatenate and compile source files, and more.
44+
- `help wanted` - Issues we need or would love help from the community to resolve.
45+
- `js` - Issues stemming from our compiled or source JavaScript files.
46+
- `meta` - Issues with the project itself or our GitHub repository.
47+
48+
For a complete look at our labels, see the [project labels page](/twbs/bootstrap/labels).
49+
50+
3251
## Bug reports
3352

3453
A bug is a _demonstrable problem_ that is caused by the code in the repository.
3554
Good bug reports are extremely helpful, so thanks!
3655

3756
Guidelines for bug reports:
3857

58+
0. **Validate and lint your code** — [validate your HTML](http://html5.validator.nu)
59+
and [lint your HTML](https://github.com/twbs/bootlint) to ensure your
60+
problem isn't caused by a simple error in your own code.
61+
3962
1. **Use the GitHub issue search** — check if the issue has already been
4063
reported.
4164

@@ -44,7 +67,7 @@ Guidelines for bug reports:
4467

4568
3. **Isolate the problem** — ideally create a [reduced test
4669
case](http://css-tricks.com/6263-reduced-test-cases/) and a live example.
47-
[This JS Bin](http://jsbin.com/EBAwOkOK/1) is a helpful template.
70+
[This JS Bin](http://jsbin.com/lefey/1/edit?html,output) is a helpful template.
4871

4972

5073
A good bug report shouldn't leave others needing to chase you up for more
@@ -72,6 +95,22 @@ Example:
7295
> causing the bug, and potential solutions (and your opinions on their
7396
> merits).
7497
98+
### Reporting upstream browser bugs
99+
100+
Sometimes bugs reported to us are actually caused by bugs in the browser(s) themselves, not bugs in Bootstrap per se.
101+
When feasible, we aim to report such upstream bugs to the relevant browser vendor(s), and then list them on our [Wall of Browser Bugs](http://getbootstrap.com/browser-bugs/).
102+
103+
| Vendor(s) | Browser(s) | Rendering engine | Bug reporting website(s) | Notes |
104+
| ------------- | ---------------------------- | ---------------- | ------------------------------------------------------------------------------------- | -------------------------------------------------------- |
105+
| Mozilla | Firefox | Gecko | https://bugzilla.mozilla.org/enter_bug.cgi | "Core" is normally the right product option to choose. |
106+
| Apple | Safari | WebKit | https://bugs.webkit.org/enter_bug.cgi?product=WebKit <br> https://bugreport.apple.com | In Apple's bug reporter, choose "Safari" as the product. |
107+
| Google, Opera | Chrome, Chromium, Opera v15+ | Blink | https://code.google.com/p/chromium/issues/list | Click the "New issue" button. |
108+
| Microsoft | Internet Explorer | Trident | https://connect.microsoft.com/IE/feedback/LoadSubmitFeedbackForm | |
109+
110+
### Issues bots
111+
112+
[@twbs-lmvtfy](https://github.com/twbs-lmvtfy) is a Bootstrap bot that hangs out in our GitHub issue tracker and automatically checks for HTML validation errors in live examples (e.g. jsFiddles, JS Bins, Bootplys, Plunks, CodePens, etc.) posted in issue comments. If it finds any errors, it will post a follow-up comment on the issue and point out the errors. If this happens with an example you've posted, please fix the errors and post an updated live example. If you opened a bug report, please check whether the bug still occurs with your revised, valid live example. If the bug no longer occurs, it was probably due to your invalid HTML rather than something in Bootstrap and we'd appreciate it if you could close out the GitHub issue.
113+
75114

76115
## Feature requests
77116

@@ -96,6 +135,17 @@ Please adhere to the [coding guidelines](#code-guidelines) used throughout the
96135
project (indentation, accurate comments, etc.) and any other requirements
97136
(such as test coverage).
98137

138+
**Do not edit `bootstrap.css`, `bootstrap-theme.css`, or `bootstrap.js`
139+
directly!** Those files are automatically generated. You should edit the
140+
source files in [`/bootstrap/less/`](https://github.com/twbs/bootstrap/tree/master/less)
141+
and/or [`/bootstrap/js/`](https://github.com/twbs/bootstrap/tree/master/js) instead.
142+
143+
Similarly, when contributing to Bootstrap's documentation, you should edit the
144+
documentation source files in
145+
[the `/bootstrap/docs/` directory of the `master` branch](https://github.com/twbs/bootstrap/tree/master/docs).
146+
**Do not edit the `gh-pages` branch.** That branch is generated from the
147+
documentation source files and is managed separately by the Bootstrap Core Team.
148+
99149
Adhering to the following process is the best way to get your work
100150
included in the project:
101151

@@ -149,30 +199,30 @@ included in the project:
149199
**IMPORTANT**: By submitting a patch, you agree to allow the project owners to
150200
license your work under the terms of the [MIT License](LICENSE.md).
151201

202+
### Pull request bots
203+
204+
[@twbs-rorschach](https://github.com/twbs-rorschach) is a Bootstrap bot that hangs out in our GitHub issue tracker and automatically checks all pull requests for a few simple common mistakes. It's possible that Rorschach might leave a comment on your pull request and then close it. If that happens, simply fix the problem(s) mentioned in the comment (there should be link(s) in the comment explaining the problem(s) in detail) and then either:
205+
206+
* Push the revised version to your pull request's branch and post a comment on the pull request saying that you've fixed the problem(s). One of the Bootstrap Core Team members will then come along and reopen your pull request.
207+
* Or you can just open a new pull request for your revised version.
208+
209+
[@twbs-savage](https://github.com/twbs-savage) is a Bootstrap bot that automatically runs cross-browser tests (via [Sauce](https://saucelabs.com) and Travis CI) on JavaScript pull requests. Savage will leave a comment on pull requests stating whether cross-browser JS tests passed or failed, with a link to the full Travis build details. If your pull request fails, check the Travis log to see which browser + OS combinations failed. Each browser test in the Travis log includes a link to a Sauce page with details about the test. On those details pages, you can watch a screencast of the test run to see exactly which unit tests failed.
210+
152211

153212
## Code guidelines
154213

155214
### HTML
156215

157-
- Two spaces for indentation, never tabs.
158-
- Double quotes only, never single quotes.
159-
- Always use proper indentation.
216+
[Adhere to the Code Guide.](http://codeguide.co/#html)
217+
160218
- Use tags and elements appropriate for an HTML5 doctype (e.g., self-closing tags).
161219
- Use CDNs and HTTPS for third-party JS when possible. We don't use protocol-relative URLs in this case because they break when viewing the page locally via `file://`.
162220
- Use [WAI-ARIA](https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA) attributes in documentation examples to promote accessibility.
163221

164222
### CSS
165223

166-
- CSS changes must be done in `.less` files first, never just in the compiled `.css` files.
167-
- Adhere to the [CSS property order](http://markdotto.com/2011/11/29/css-property-order/).
168-
- Multiple-line approach (one property and value per line).
169-
- Always a space after a property's colon (e.g., `display: block;` and not `display:block;`).
170-
- End all lines with a semi-colon.
171-
- For multiple, comma-separated selectors, place each selector on its own line.
172-
- Attribute selectors, like `input[type="text"]` should always wrap the attribute's value in double quotes, for consistency and safety (see this [blog post on unquoted attribute values](http://mathiasbynens.be/notes/unquoted-attribute-values) that can lead to XSS attacks).
173-
- Attribute selectors should only be used where absolutely necessary (e.g., form controls) and should be avoided on custom components for performance and explicitness.
174-
- Series of classes for a component should include a base class (e.g., `.component`) and use the base class as a prefix for modifier and sub-components (e.g., `.component-lg`).
175-
- Avoid inheritance and over nesting—use single, explicit classes whenever possible.
224+
[Adhere to the Code Guide.](http://codeguide.co/#css)
225+
176226
- When feasible, default color palettes should comply with [WCAG color contrast guidelines](http://www.w3.org/TR/WCAG20/#visual-audio-contrast).
177227
- Except in rare cases, don't remove default `:focus` styles (via e.g. `outline: none;`) without providing alternative styles. See [this A11Y Project post](http://a11yproject.com/posts/never-remove-css-outlines/) for more details.
178228

@@ -193,4 +243,3 @@ Run `grunt test` before committing to ensure your changes follow our coding stan
193243
By contributing your code, you agree to license your contribution under the [MIT license](https://github.com/twbs/bootstrap/blob/master/LICENSE).
194244

195245
Prior to v3.1.0, Bootstrap was released under the Apache License v2.0.
196-

0 commit comments

Comments
 (0)